Slightly enhance setup.py
#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more fields to setuptools.setup(), including classifiers and keywords for greater discoverability. It also adds a standard copyright header.
Adding cmake to `setup_requires` helps make this more portable to environments where cmake is not installed as a system tool.
Strilanc
reviewed
Oct 24, 2025
Strilanc
approved these changes
Oct 30, 2025
As Craig pointed out, some didn't apply to this, and others were probably insufficiently helpful.
mhucka
added a commit
that referenced
this pull request
Dec 1, 2025
Changes: * Add `cmake` to `setup_requires` in `setuptools.setup`. This helps ensure that builds get a known version of `cmake` even if it's not installed on the host system. * Add more fields to setuptools.setup(), including classifiers and keywords for greater discoverability. * Add the usual license header at the top of the file. * Fix a linter complaint about the call to `open`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
cmaketosetup_requiresinsetuptools.setup. This helps ensure that builds get a known version ofcmakeeven if it's not installed on the host system.open.