Skip to content

Integrate Mozilla's mtu crate to constrain MTU discovery #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ali-molajani wants to merge 3 commits into
base: main
Choose a base branch
from
+220 −24
Open

Integrate Mozilla's mtu crate to constrain MTU discovery #2465

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b3ccb9
Integrate Mozilla's mtu crate to constrain MTU discovery
ali-molajani Dec 6, 2025
9a4b27e
There was potential to return None, solved
ali-molajani Dec 8, 2025
477c62c
Merge branch 'main' into main
ali-molajani Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 138 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion quinn-proto/src/connection/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ impl Connection {
allow_mtud: bool,
rng_seed: [u8; 32],
side_args: SideArgs,
interface_mtu_constraint: Option<u16>,
) -> Self {
let pref_addr_cid = side_args.pref_addr_cid();
let path_validated = side_args.path_validated();
Expand All @@ -283,7 +284,7 @@ impl Connection {
now,
if pref_addr_cid.is_some() { 2 } else { 1 },
),
path: PathData::new(remote, allow_mtud, None, 0, now, &config),
path: PathData::new(remote, allow_mtud, None, 0, now, &config, interface_mtu_constraint),
Copy link
Member

@djc djc Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we drop the interface_ prefix in names? It seems pretty verbose and it's not like we have a bunch of other MTU constraints right now (can expand more on it in documentation).

path_counter: 0,
allow_mtud,
local_ip,
Expand Down Expand Up @@ -3122,6 +3123,7 @@ impl Connection {
self.path_counter,
now,
&self.config,
None, // Interface MTU constraint not available for path migration
)
};
new_path.challenge = Some(self.rng.random());
Expand Down
Loading
Loading