Remove usage of internal function in CI tests #2597
Conversation
| #' @param source_expression A source_expression. | ||
| #' @param token_type Restrict analysis to tokens of this type, for example, | ||
| #' with `token_type = "STR_CONST"` you can check that a regex match occurs | ||
| #' within a string. |
There was a problem hiding this comment.
Not related, but minor docs clean-up. Didn't want to create a separate PR just for this change.
R/make_linter_from_regex.R
Outdated
| #' with token_type = "STR_CONST" you can check that a regex match occurs | ||
| #' within a string | ||
| #' @param match The position where a regex match was observed. | ||
| #' Possible values: `"start"`, `"end"`, and `"line_number"`. |
There was a problem hiding this comment.
IMO this is not the correct way to document the required entries.
There was a problem hiding this comment.
Note that this is an internal function, and we don't even generate the .Rd file.
What change would you like me to make?
There was a problem hiding this comment.
To me the old doc was fine.
The attributes are required, not optional. "Possible" suggests otherwise.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
- Coverage 98.15% 98.08% -0.07%
==========================================
Files 125 126 +1
Lines 5738 5740 +2
==========================================
- Hits 5632 5630 -2
- Misses 106 110 +4 ☔ View full report in Codecov by Sentry. |
IndrajeetPatil
added
the
internals
Co-authored-by: AshesITR <[email protected]>
cf. #1692