Skip to content

Remove usage of internal function in CI tests #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Remove usage of internal function in CI tests #2597

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd2c789
Remove usage of internal function in CI tests
IndrajeetPatil Jun 7, 2024
5c37d71
tweak docs
IndrajeetPatil Jun 8, 2024
da02131
Update R/make_linter_from_regex.R
IndrajeetPatil Jun 8, 2024
ca96639
Merge branch 'main' into test-ci-remove-internal
IndrajeetPatil Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions R/make_linter_from_regex.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ make_linter_from_regex <- function(regex,

#' Determine if a regex match is covered by an expression in a source_expression
#'
#' @param match The position where a regex match was observed.
#' match must have entries "start", "end", and "line_number".
#' @param source_expression A source_expression
#' @param token_type Restrict analysis to tokens of this type, for example,
#' with token_type = "STR_CONST" you can check that a regex match occurs
#' within a string
#' @param match The position where a regex match was observed.
#' It must have following entries: `"start"`, `"end"`, and `"line_number"`.
#' @param source_expression A source_expression.
#' @param token_type Restrict analysis to tokens of this type, for example,
#' with `token_type = "STR_CONST"` you can check that a regex match occurs
#' within a string.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but minor docs clean-up. Didn't want to create a separate PR just for this change.

#' @noRd
is_match_covered <- function(match, source_expression, token_type = "STR_CONST") {
line_number <- match$line_number
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-ci.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ test_that("GitHub Actions functionality works in a subdirectory", {
withr::local_envvar(list(GITHUB_ACTIONS = "true"))
withr::local_options(lintr.rstudio_source_markers = FALSE, lintr.github_annotation_project_dir = pkg_path)

lintr:::read_settings(NULL)
l <- lint_package(
pkg_path,
linters = list(assignment_linter()),
Expand Down
Loading