-
Notifications
You must be signed in to change notification settings - Fork 188
Remove usage of internal function in CI tests #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,12 +34,12 @@ make_linter_from_regex <- function(regex, | |
|
||
#' Determine if a regex match is covered by an expression in a source_expression | ||
#' | ||
#' @param match The position where a regex match was observed. | ||
#' match must have entries "start", "end", and "line_number". | ||
#' @param source_expression A source_expression | ||
#' @param token_type Restrict analysis to tokens of this type, for example, | ||
#' with token_type = "STR_CONST" you can check that a regex match occurs | ||
#' within a string | ||
#' @param match The position where a regex match was observed. | ||
#' It must have following entries: `"start"`, `"end"`, and `"line_number"`. | ||
#' @param source_expression A source_expression. | ||
#' @param token_type Restrict analysis to tokens of this type, for example, | ||
#' with `token_type = "STR_CONST"` you can check that a regex match occurs | ||
#' within a string. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not related, but minor docs clean-up. Didn't want to create a separate PR just for this change. |
||
#' @noRd | ||
is_match_covered <- function(match, source_expression, token_type = "STR_CONST") { | ||
line_number <- match$line_number | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.