Attempt to reduce flakiness of recurring_tasks_test
#684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-schlickmann
force-pushed
the
recurring-flaky-tests
branch
2 times, most recently
from
393f0ec to
7ee0213
Compare
p-schlickmann
force-pushed
the
recurring-flaky-tests
branch
from
7ee0213 to
f99a756
Compare
Contributor
Author
|
Green CI = instant dopamine 🤩 |
p-schlickmann
commented
Nov 17, 2025
| SolidQueue::Process.destroy_all | ||
| SolidQueue::Job.destroy_all | ||
| SolidQueue::RecurringTask.delete_all | ||
| JobResult.delete_all |
Contributor
Author
There was a problem hiding this comment.
removed this from teardown since it's already handled in test_helper.rb teardown
rosa
reviewed
Nov 17, 2025
|
|
||
| terminate_process(pid) | ||
| wait_for_registered_processes(0, timeout: SolidQueue.shutdown_timeout) | ||
| sleep SolidQueue.shutdown_timeout |
Member
There was a problem hiding this comment.
Why is this extra sleep necessary?
Contributor
Author
There was a problem hiding this comment.
Good point! I guess I was being extra cautious while debugging this, it seemed worth it because shutdown_timeout is only 2 seconds. But I tested locally and it runs fine without it. Thanks!
rosa
reviewed
Nov 17, 2025
| end | ||
| end | ||
|
|
||
| # no need to stop @pid supervisor - that will be handled in teardown |
Member
There was a problem hiding this comment.
Thank you! I think we can remove this comment, as I think most people won't wonder about this 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #602
Flake: recurring_tasks_test.rb
Failed run: https://github.com/rails/solid_queue/actions/runs/18916883193/job/54002506057
Instructions to validate the fix locally: #678
Summary
I found a race condition in recurring_tasks_test.rb which tries to stop the supervisor twice. Once inside the test and once again in
teardown.When synchronized enough, the first shutdown worked, and the second one tried to stop a process that had already exited. That second attempt escalated to a
KILLinstead of a cleanTERM, which is why the assertion failed in CI.The fix makes sure we only stop the supervisor once, removing the double-shutdown race.