Skip to content

Attempt to reduce flakiness of recurring_tasks_test #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Attempt to reduce flakiness of recurring_tasks_test #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f99a756
Attempt to reduce flakiness of `recurring_tasks_test`
p-schlickmann Nov 17, 2025
532d719
Removing comments && extra sleep
p-schlickmann Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions test/integration/recurring_tasks_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,17 @@ class RecurringTasksTest < ActiveSupport::TestCase
self.use_transactional_tests = false

setup do
@pid = run_supervisor_as_fork(skip_recurring: false)
# 1 supervisor + 2 workers + 1 dispatcher + 1 scheduler
wait_for_registered_processes(5, timeout: 3.second)
@pid = run_recurring_supervisor
end

teardown do
terminate_process(@pid) if process_exists?(@pid)

SolidQueue::Process.destroy_all
SolidQueue::Job.destroy_all
SolidQueue::RecurringTask.delete_all
JobResult.delete_all
Copy link
Contributor Author

@p-schlickmann p-schlickmann Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this from teardown since it's already handled in test_helper.rb teardown

terminate_gracefully(@pid)
end

test "enqueue and process periodic tasks" do
wait_for_jobs_to_be_enqueued(2, timeout: 2.5.seconds)
wait_for_jobs_to_finish_for(2.5.seconds)

terminate_process(@pid)

skip_active_record_query_cache do
assert SolidQueue::Job.count >= 2
SolidQueue::Job.all.each do |job|
Expand All @@ -43,20 +34,14 @@ class RecurringTasksTest < ActiveSupport::TestCase

test "persist and delete configured tasks" do
configured_task = { periodic_store_result: { class: "StoreResultJob", schedule: "every second" } }
# Wait for concurrency schedule loading after process registration
sleep(0.5)

assert_recurring_tasks configured_task
terminate_process(@pid)

task = SolidQueue::RecurringTask.find_by(key: "periodic_store_result")
task.update!(class_name: "StoreResultJob", schedule: "every minute", arguments: [ 42 ])

@pid = run_supervisor_as_fork(skip_recurring: false)
wait_for_registered_processes(5, timeout: 3.second)
terminate_gracefully(@pid)

# Wait for concurrency schedule loading after process registration
sleep(0.5)
@pid = run_recurring_supervisor

assert_recurring_tasks configured_task

Expand All @@ -72,7 +57,6 @@ class RecurringTasksTest < ActiveSupport::TestCase

assert_recurring_tasks updated_task

terminate_process(@pid)
scheduler1.stop
scheduler2.stop
end
Expand All @@ -92,4 +76,18 @@ def assert_recurring_tasks(expected_tasks)
end
end
end

def run_recurring_supervisor
pid = run_supervisor_as_fork(skip_recurring: false)
wait_for_registered_processes(5, timeout: 3.seconds) # 1 supervisor + 2 workers + 1 dispatcher + 1 scheduler
sleep 1.second # Wait for concurrency schedule loading after process registration
pid
end

def terminate_gracefully(pid)
return if pid.nil? || !process_exists?(pid)

terminate_process(pid)
wait_for_registered_processes(0, timeout: SolidQueue.shutdown_timeout)
end
end