Skip to content

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Aug 26, 2025

What changed

  • Created a unified E2E test runner script (e2e.sh) that replaces multiple separate scripts
  • Added support for headless/headed browser testing with HEADLESS_MODE environment variable (on by default)
  • Updated all E2E test commands in package.json to use the new unified script
  • Improved test path handling to allow running specific test files or directories
  • Updated GitHub workflows to use the new E2E commands
  • Enhanced documentation in README.md and CLAUDE.md with clearer E2E test instructions
  • Added better chain configuration handling for different test environments

What to test

  • Run E2E tests with the new commands:
    • yarn e2e - runs all tests in headless mode
    • yarn e2e:headed - runs tests with visible browser
    • yarn e2e serial/send/1_sendFlow.test.ts - runs a specific test file
    • yarn e2e ./e2e/parallel/ - runs all tests in a directory
  • Verify that the specialized test commands still work:
    • yarn e2e:parallel
    • yarn e2e:swap
    • yarn e2e:send
    • yarn e2e:send:optimism
    • yarn e2e:dappInteractions
  • Check that the GitHub workflows execute correctly with the updated commands

PR-Codex overview

This PR focuses on restructuring end-to-end (E2E) testing scripts, enhancing the functionality and clarity of E2E tests while removing outdated scripts.

Detailed summary

  • Deleted legacy E2E test scripts: scripts/e2e-serial-tests.sh, scripts/e2e-parallel-tests.sh, scripts/e2e-op-serial-tests.sh.
  • Updated README.md to reflect new E2E test commands and options.
  • Modified .github/workflows/claude-review.yml to adjust disallowed tools.
  • Enhanced e2e/helpers.ts to support headless mode for Firefox and Chrome.
  • Updated package.json to replace old scripts with a unified ./scripts/e2e.sh script for E2E tests.
  • Added a new scripts/e2e.sh script that consolidates E2E test execution with options for parallel and serial tests.
  • Adjusted .github/workflows/build.yml to use new E2E commands instead of deprecated vitest commands.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@DanielSinclair
Copy link
Collaborator Author

DanielSinclair commented Aug 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 26, 2025
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch 2 times, most recently from c7b3f60 to e3d2351 Compare August 26, 2025 21:29
@DanielSinclair DanielSinclair marked this pull request as ready for review August 27, 2025 06:09
@DanielSinclair DanielSinclair changed the base branch from _daniel/chrome-139 to graphite-base/2012 August 27, 2025 17:09
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from e3d2351 to 7752529 Compare August 27, 2025 17:09
@DanielSinclair DanielSinclair changed the base branch from graphite-base/2012 to master August 27, 2025 17:09
@DanielSinclair DanielSinclair marked this pull request as draft August 28, 2025 03:25
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from 7752529 to cee8510 Compare August 28, 2025 04:30
Revert "e2e headless mode defaults"

This reverts commit 61fbf12ee43f51ac97e186fa15673ee890b52e08.

Reapply "e2e headless mode defaults"

This reverts commit cc9cde4e9dbd554ec21989638043e2d6dcc76083.

fix: headless mode
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from e90c1cf to 8ab8695 Compare September 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant