Skip to content

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Aug 26, 2025

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test


PR-Codex overview

This PR focuses on cleaning up and updating end-to-end (e2e) test mocks, improving the structure for handling swap quotes and slippage responses, and enhancing the network interception functionality.

Detailed summary

  • Deleted multiple mock files related to swap_quotes.
  • Added new JSON files for slippage responses with varying slippagePercent.
  • Introduced error responses for specific swap quote requests.
  • Updated package.json to use selenium-webdriver version 4.35.0.
  • Modified vitest.config.ts to include e2e test files.
  • Enhanced initDriverWithOptions function to include network interception.
  • Added new TypeScript definitions for BiDi event types.
  • Updated endpoints.ts to configure service endpoints for mocks.
  • Created a new README for the e2e mock system explaining usage and structure.

The following files were skipped due to too many changes: e2e/mocks/swap/quote/0xc26272c5bf19cd649972abbac018d89c6d8a5c07d70719c464f63dfadbaa9ac7.json, e2e/mocks/swap/quote/0x379416b0e8e9f9e36b45eec57b1978238f5af1496206e9a8ce28dddfe3945ed7.json, e2e/mocks/swap/quote/0x47340cf37ec568d85c017c8c9cacfb330a6aefd1515158e75066ad213bf7cc1f.json, e2e/mocks/swap/quote/0x5b069bb5fcbc7762c47959f7b44a6b9ef0bec6284bdc7e4233ae746bcc596368.json, e2e/mocks/swap/quote/0x939bdc6a9c8d3d009be3e4daa82c2a06a0db30353cd50d2a607c53cbba045001.json, e2e/mocks/swap/quote/0xd340e47b8638803ad11ee4a801d39e1553126acdec24f8bd8b8fca32eeef4917.json, e2e/mocks/intercept.ts, e2e/mocks/swap/quote/0xd37cfab3f9456439dc8c0cdfee67eb993e67ac7b14ddd6be49a961d1955c28c1.json, e2e/mocks/intercept.test.ts, e2e/mocks/swap/quote/0x00eee74c6fa73c08ecaccb23d69352a4ecfb03c0fc7e2258ace1d63b0264abc2.json, e2e/mocks/addys/assets/65f97e5bf8a615abd30000dde6bb58f411526ad1d32161d9b1d341883f358335.json, e2e/mocks/swap/quote/0x380e8f14b89b3978200ba3ebdf88ac6174b8a3b404b29365546e983e9ab1e587.json, e2e/mocks/swap/quote/0xebd75d0517e2e15e1b4ff167ad5c4f2c214e9e0f65224c2b8acd1c5d4902523f.json, e2e/mocks/swap/quote/0x66297c56338a4369baea388ffc78f69380944266107ebf957b7b65eb98fe036a.json, e2e/mocks/swap/quote/0x741198ed8cce7db26e5189437e915752765779b3800aa8b4492c5895f34e7204.json, e2e/mocks/swap/quote/0xaf758611b699ddb0772bfb18d394fda79babed75e02c6ec68787f8ec8c4b6a5e.json, e2e/mocks/swap/quote/0x90c3bea3971a8eceec9f69672f8792f62f780eff333bc308ce72544e61141289.json, e2e/mocks/swap/quote/0xb8d81e75e8537dd8b96f3e9a79968ad795560aa0cba40b4297e1c164b6e3106a.json, e2e/mocks/swap/quote/0x32c0b9ce96014842fb892fc278855ca510fa9d9de64fc2fe3e9f3ef2d704357d.json, e2e/mocks/addys/assets/2969ef62150aee982aba2336793b380da329324b6293266acd6caf7a3f7ce274.json, e2e/mocks/addys/assets/aca2413fbf021eeb4cee4a53622a7cf1baaaff8fd370af8288a63e3a46088a6d.json, e2e/mocks/addys/assets/ced989687f1792c2fb8efe6ba209d91d918eb1a7d590c8809560aa507dfc28ec.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@DanielSinclair
Copy link
Collaborator Author

DanielSinclair commented Aug 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

socket-security bot commented Aug 26, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedselenium-webdriver@​4.34.0 ⏵ 4.35.098 +110010091 -1100

View full report

@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from 2da8634 to e9cd84b Compare August 26, 2025 18:18
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from 43f1082 to c7b3f60 Compare August 26, 2025 19:52
@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from e9cd84b to 4e57e35 Compare August 26, 2025 19:52
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from c7b3f60 to e3d2351 Compare August 26, 2025 21:29
@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from 4e57e35 to 226fef1 Compare August 26, 2025 21:29
@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from 226fef1 to cdd97b5 Compare August 27, 2025 17:09
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from e3d2351 to 7752529 Compare August 27, 2025 17:09
@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from cdd97b5 to a07c81f Compare August 28, 2025 04:30
@DanielSinclair DanielSinclair force-pushed the daniel/e2e-script-refactor branch from 7752529 to cee8510 Compare August 28, 2025 04:30
@DanielSinclair DanielSinclair changed the base branch from daniel/e2e-script-refactor to graphite-base/2013 September 16, 2025 22:37
@DanielSinclair DanielSinclair force-pushed the daniel/bidi-mock-interceptor branch from a07c81f to d7a17c2 Compare September 16, 2025 22:37
@DanielSinclair DanielSinclair changed the base branch from graphite-base/2013 to master September 16, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants