-
Notifications
You must be signed in to change notification settings - Fork 63
refactor: bidi mock interceptor #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DanielSinclair
wants to merge
2
commits into
master
Choose a base branch
from
daniel/bidi-mock-interceptor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2da8634
to
e9cd84b
Compare
43f1082
to
c7b3f60
Compare
e9cd84b
to
4e57e35
Compare
c7b3f60
to
e3d2351
Compare
4e57e35
to
226fef1
Compare
This was referenced Aug 26, 2025
226fef1
to
cdd97b5
Compare
e3d2351
to
7752529
Compare
cdd97b5
to
a07c81f
Compare
7752529
to
cee8510
Compare
cee8510
to
c23fcf4
Compare
a07c81f
to
d7a17c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test
PR-Codex overview
This PR focuses on cleaning up and updating end-to-end (e2e) test mocks, improving the structure for handling swap quotes and slippage responses, and enhancing the network interception functionality.
Detailed summary
swap_quotes
.slippage
responses with varyingslippagePercent
.swap
quote requests.package.json
to useselenium-webdriver
version4.35.0
.vitest.config.ts
to include e2e test files.initDriverWithOptions
function to include network interception.endpoints.ts
to configure service endpoints for mocks.