-
Notifications
You must be signed in to change notification settings - Fork 63
feat: migrate assets to plattform #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/core/resources/assets/userAssets.ts
|
b35cbe2
to
c0f357c
Compare
@@ -0,0 +1,110 @@ | |||
// Code generated by protoc-gen-ts_proto. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name mismatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a few errors (tested up to the transaction migration in the stack):


Token data doesn't look prod ready; think we need to hold-off on this until the backend endpoint is more usable
Token values/filtering and frontend handling:
Chart smoothing looks like there is an issue (I think this explains the SVG error):
cf6a6f8
to
867257a
Compare
867257a
to
e5c0258
Compare
Adds Platform API integration for asset balances
Fixes BX-2026
Fixes BX-2027
What changed (plus any additional context for devs)
What to test
PR-Codex overview
This PR introduces support for a new
platformValue
feature in the asset management system, allowing for additional asset pricing information from a new API. It updates various components, types, and utilities to integrate this feature seamlessly.Detailed summary
PLATFORM_API_KEY
to.env.example
and.env.d.ts
.platformHttp
insrc/core/network/platform.ts
.ParsedUserAsset
interface to includeplatformValue
.platformValue
.platformValue
.platformValue
prominently.