Skip to content

Conversation

janek26
Copy link
Contributor

@janek26 janek26 commented Oct 9, 2025

Migrate activities to plattform

Fixes BX-2028
Fixes BX-2029
Fixes BX-2030

What changed (plus any additional context for devs)

This PR migrates transaction-related API calls from the Addys service to the Platform service. The changes include:

  • Updated consolidatedTransactions.ts to use the Platform API endpoint for listing transactions
  • Modified transaction.ts to fetch transaction details using the Platform API
  • Updated transactions.ts to use the Platform API for transaction listing
  • Added Platform transaction type definitions in src/core/types/gen/plattform/transaction/transaction.ts
  • Added utility functions to convert Platform transaction responses to the existing API response format

What to test

  • Verify that transaction history loads correctly in the UI
  • Check that transaction details can be viewed for individual transactions
  • Ensure pagination works when scrolling through transaction history
  • Confirm that transactions appear with the correct status (pending, confirmed, failed)
  • Test across different networks to ensure chain-specific transactions load properly
  • Verify that transaction filtering works as expected

PR-Codex overview

This PR focuses on refactoring the transaction handling logic to use a new platform API, replacing the previous addysHttp with platformHttp. It enhances transaction fetching and processing, ensuring compatibility with the new data structure.

Detailed summary

  • Replaced addysHttp with platformHttp in multiple files.
  • Updated transaction fetching logic to use new API endpoints.
  • Introduced nullish coalescing for tx.changes to handle undefined cases.
  • Added new utility functions for transaction normalization and conversion.
  • Updated type imports to reflect the new platform's API response structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@janek26
Copy link
Contributor Author

janek26 commented Oct 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

sentry-io bot commented Oct 9, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/core/resources/transactions/consolidatedTransactions.ts

Function Unhandled Issue
consolidatedTransactionsQueryFunction Error: HTTP Client Error with status code: 502 /p...
Event Count: 1 Affected Users: 1

@janek26 janek26 force-pushed the feature/plattform-assets branch from d56c3b6 to b35cbe2 Compare October 9, 2025 13:19
@janek26 janek26 force-pushed the feature/plattform-transactions branch 2 times, most recently from 63915d0 to 5a4f950 Compare October 9, 2025 13:20
@janek26 janek26 force-pushed the feature/plattform-assets branch from b35cbe2 to c0f357c Compare October 10, 2025 12:45
@janek26 janek26 force-pushed the feature/plattform-transactions branch from 5a4f950 to 78ca69b Compare October 10, 2025 12:45
@janek26 janek26 marked this pull request as ready for review October 10, 2025 14:45
@@ -0,0 +1,619 @@
// Code generated by protoc-gen-ts_proto. DO NOT EDIT.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory mismatch

@janek26 janek26 force-pushed the feature/plattform-assets branch from 0f386d3 to cf6a6f8 Compare October 15, 2025 09:27
@janek26 janek26 force-pushed the feature/plattform-transactions branch 2 times, most recently from 15be28a to 80942ad Compare October 15, 2025 13:47
@janek26 janek26 force-pushed the feature/plattform-assets branch from cf6a6f8 to 867257a Compare October 15, 2025 13:47
@janek26 janek26 force-pushed the feature/plattform-assets branch from 867257a to e5c0258 Compare October 15, 2025 14:39
@janek26 janek26 force-pushed the feature/plattform-transactions branch from 80942ad to 086b40e Compare October 15, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants