Implement authorisation rules #1523 #1597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g items between systems
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
…o implement-authorisation-for-bypassing-rules-#1523
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## implement-base-authorisation-#1472 #1597 +/- ##
======================================================================
- Coverage 98.82% 98.66% -0.17%
======================================================================
Files 114 115 +1
Lines 21920 22728 +808
Branches 2512 2613 +101
======================================================================
+ Hits 21663 22425 +762
- Misses 256 302 +46
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joelvdavies
reviewed
Nov 13, 2025
src/systems/__snapshots__/systemItemsDialog.component.test.tsx.snap
Outdated
Show resolved
Hide resolved
joshdimanteto
requested changes
Nov 14, 2025
Comment on lines
+138
to
+162
| const populateUsageStatuses = React.useCallback(() => { | ||
| const usageStatusId = | ||
| srcSystemTypeId === dstSystemTypeId || selectedRules?.length === 0 | ||
| ? undefined | ||
| : selectedRules?.[0]?.dst_usage_status?.id; | ||
|
|
||
| setUsageStatuses( | ||
| usageStatuses.map((usage_status) => { | ||
| return { | ||
| ...usage_status, | ||
| usage_status_id: | ||
| usageStatusId ?? | ||
| selectedItems.find((item) => item.id == usage_status.item_id) | ||
| ?.usage_status_id ?? | ||
| '', | ||
| }; | ||
| }) | ||
| ); | ||
| }, [ | ||
| dstSystemTypeId, | ||
| selectedItems, | ||
| selectedRules, | ||
| srcSystemTypeId, | ||
| usageStatuses, | ||
| ]); |
Contributor
There was a problem hiding this comment.
This works well with the expected current data volume. Just a note: if usage statuses or selected items become large, this population step could weirdness when moving to the next step.
Not urgent, but something to keep an eye on.
Contributor
|
Works well, just a few minor comments to address |
…union, and address other comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see #1472
Note this PR follows on from #1518 but does not need to wait on any PRs in ims-api or ldap
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1472