Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cudf::grouped_time_range_rolling_window #17589

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Open

Deprecate cudf::grouped_time_range_rolling_window #17589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5366e5
Deprecate cudf::grouped_time_range_rolling_window
wence- Dec 13, 2024
1f2b4ab
Merge branch 'branch-25.02' into wence/fea/rolling-deprecate
wence- Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cpp/include/cudf/rolling.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cudf/aggregation.hpp>
#include <cudf/rolling/range_window_bounds.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/export.hpp>
Expand Down Expand Up @@ -322,6 +323,8 @@ std::unique_ptr<column> grouped_rolling_window(
* @brief Applies a grouping-aware, timestamp-based rolling window function to the values in a
* column.
*
* @deprecated Since 25.02, to be removed in 25.04
*
* Like `rolling_window()`, this function aggregates values in a window around each
* element of a specified `input` column. It differs from `rolling_window()` in two respects:
* 1. The elements of the `input` column are grouped into distinct groups (e.g. the result of a
Expand Down Expand Up @@ -403,7 +406,8 @@ std::unique_ptr<column> grouped_rolling_window(
*
* @returns A nullable output column containing the rolling window results
*/
std::unique_ptr<column> grouped_time_range_rolling_window(
[[deprecated("Use cudf::grouped_range_rolling_window instead")]] std::unique_ptr<column>
grouped_time_range_rolling_window(
table_view const& group_keys,
column_view const& timestamp_column,
cudf::order const& timestamp_order,
Expand All @@ -419,6 +423,8 @@ std::unique_ptr<column> grouped_time_range_rolling_window(
* @brief Applies a grouping-aware, timestamp-based rolling window function to the values in a
* column,.
*
* @deprecated Since 25.02, to be removed in 25.04
*
* @details @copydetails grouped_time_range_rolling_window(
* table_view const& group_keys,
* column_view const& timestamp_column,
Expand All @@ -434,7 +440,8 @@ std::unique_ptr<column> grouped_time_range_rolling_window(
* The `preceding_window_in_days` and `following_window_in_days` are specified as a `window_bounds`
* and supports "unbounded" windows, if set to `window_bounds::unbounded()`.
*/
std::unique_ptr<column> grouped_time_range_rolling_window(
[[deprecated("Use cudf::grouped_range_rolling_window instead")]] std::unique_ptr<column>
grouped_time_range_rolling_window(
table_view const& group_keys,
column_view const& timestamp_column,
cudf::order const& timestamp_order,
Expand Down
Loading
Loading