Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible overflow in WriteCoalescingCallbackWrapper::TearDown #17642

Merged
merged 7 commits into from
Jan 3, 2025

Conversation

davidwendt
Copy link
Contributor

Description

Fixes possible overflow in WriteCoalescingCallbackWrapper::TearDown function if the tile_out_count is sufficiently large enough. The out_char += blockDim.x could overflow when within block-size of the max of tile_out_count.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 20, 2024
@davidwendt davidwendt self-assigned this Dec 20, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 20, 2024 16:56
@davidwendt
Copy link
Contributor Author

This may not be likely since tile_out_count is unsigned so has a much larger max size and may not practically ever be significantly large. It was difficult to trace down what the possible value range is expected here.

@PointKernel PointKernel added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 30, 2024
@davidwendt davidwendt requested a review from a team as a code owner January 2, 2025 22:21
@github-actions github-actions bot added the CMake CMake build issue label Jan 2, 2025
@github-actions github-actions bot removed the CMake CMake build issue label Jan 3, 2025
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1dece5e into rapidsai:branch-25.02 Jan 3, 2025
106 checks passed
@davidwendt davidwendt deleted the fst-overflow branch January 3, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants