Fix writing of compressed ORC files with large stripe footers #17700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
ttnghia
reviewed
Jan 9, 2025
ttnghia
reviewed
Jan 9, 2025
nvdbaranec
requested changes
Jan 9, 2025
ttnghia
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ORC, stripe footers can be compressed, the same way as the data. This means that compressed footers need to be written in multiple blocks if they are larger than the maximum block size. This applies even if the footer is actually uncompressed (in this case a flag in the block header is raised).
Currently, the ORC writer does not take into account that footer can be larger than max block size, and writes the entire thing in a single block, which is not valid.
The issue only applies to compressed files. Uncompressed files do not apply this limitation to the footers.
This PR changes the way the stripe footers are written to account for this case. The output hasn't changed for files with small stripe footers.
Checklist