chore: remove unnecessary empty rayStartParams
#3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #3547 |
davidxia
force-pushed
the
patch29
branch
2 times, most recently
from
33506db to
49f4179
Compare
davidxia
force-pushed
the
patch29
branch
15 times, most recently
from
6465363 to
56aa8b8
Compare
|
there are a few other places with |
davidxia
changed the title
rayStartParamsrayStartParams
|
would you mind rebasing with the master branch? |
kevin85421
reviewed
Jun 20, 2025
There was a problem hiding this comment.
- How about removing the comment "rayStartParams is optional with RayCluster CRD from KubeRay 1.4.0 or later but required in earlier versions"? If we add comments to all YAML files, it will be harder to maintain—we'd need to update dozens of YAML files whenever the comment changes.
- We can only add the comments to https://github.com/ray-project/kuberay/blob/master/ray-operator/config/samples/ray-cluster.sample.yaml
- We can remove
rayStartParams: {}from YAMLs for testing. For example, YAMLs underapiserver/test/cluster,memory_benchmark,perf-tests, ... etc. - However, I would suggest to keep
rayStartParams: {}for user-facing examples. I guess some users may follow the Ray website and use their existing KubeRay operator which is older than v1.4.0.
in example YAMLs and tests. `rayStartParams` is optional after ray-project#3202 released in 1.4.0. We comment out with an explanation instead of removing entirely so users with older RayCluster CRD versions have a hint about the incompatibility. Signed-off-by: David Xia <[email protected]>
Signed-off-by: David Xia <[email protected]>
|
@kevin85421 sgtm, done! |
kevin85421
approved these changes
Jun 24, 2025
davidxia
changed the title
rayStartParamsrayStartParams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in example YAMLs and tests.
rayStartParamsis optional after #3202released in 1.4.0. We remove them in YAMLs for testing but keep in user-facing examples for backwards compatibility with older CRD versions.
contributes to #3580
Checks