Skip to content

Pin redis<4.0 on M1 Macs #20521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wuisawesome
Copy link
Contributor

@wuisawesome wuisawesome commented Nov 18, 2021

Why are these changes needed?

This PR pins redis on M1 macs. Redis 4.0+ adds extra warning messages if hiredis is not installed, but hiredis doesn't provide m1 mac wheels, which makes it difficult to install.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@wuisawesome wuisawesome changed the title Pin redis<4.0 on M1 mac Pin redis<4.0 on M1 Macs Nov 18, 2021
@pcmoritz
Copy link
Contributor

pcmoritz commented Nov 18, 2021

4.0.1 was just released that should remove the warning: redis/redis-py#1721

Can you try if that fixes it? It would be preferable not to pin :)

https://github.com/redis/redis-py/releases/tag/v4.0.1

@wuisawesome
Copy link
Contributor Author

Just tested and I still get the error message. (it comes from this line: https://github.com/redis/redis-py/blob/4e9cc015e32ef305429ff9dfa200e28dd63e6663/redis/connection.py#L71)

@wuisawesome
Copy link
Contributor Author

That being said, if Redis intends to remove the error message, maybe we don't need to merge this PR, and we can just wait for them to fix it upstream?

@wuisawesome
Copy link
Contributor Author

Let me close this for now and see if redis/redis-py#1726 gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants