Skip to content

Pin redis<4.0 on M1 Macs #20521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Pin redis<4.0 on M1 Macs #20521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,11 @@ def get_packages(self):
"pyyaml",
]

if platform.system() == "Darwin" and platform.machine() == "arm64":
if platform.system() == "Windows" or (platform.system() == "Darwin"
and platform.machine() == "arm64"):
# TODO (Alex): `hiredis` doesn't have prebuilt M1 mac wheels yet. We can
# remove this, either when they add support, we remove redis, or we vendor
# redis/hiredis ourselves.
setup_spec.install_requires.append("redis >= 3.5.0")
elif platform.system() == "Windows":
# TODO (Alex): Ray is not compatible with redis >= 4.0.0. We ened to either
# investigate why, or remove the redis dependency.
setup_spec.install_requires.append("redis >= 3.5.0, < 4.0")
Expand Down