[SimpleCOMRPC] Adjust the plugin after changes to IShell::ICOMLink::INotification #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SimpleCOMRPC example plugin to align with changes to the IShell::ICOMLink::INotification interface, specifically consolidating the handling of dangling interfaces. The Revoked method has been removed in favor of using only the Dangling method for interface cleanup notifications.
Key Changes:
- Removed the
Revokedmethod implementation and consolidated its logic into theDanglingmethod - Renamed
OnRevoketoOnInterfaceDanglingto better reflect the updated interface semantics - Updated trace messages to use "dangling" terminology consistently
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/SimpleCOMRPC/PluginServer/SimpleCOMRPCPluginServer.h | Consolidated Revoked method into Dangling method and renamed callback handler |
| examples/SimpleCOMRPC/PluginServer/SimpleCOMRPCPluginServer.cpp | Renamed method implementation and updated trace message to reflect dangling interface semantics |
| examples/SimpleCOMRPC/Client/SimpleCOMRPCClient.cpp | Corrected printf format specifier from %llu to %lu |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebaszm
approved these changes
Oct 28, 2025
MFransen69
approved these changes
Oct 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.