Skip to content

[SimpleCOMRPC] Adjust the plugin after changes to IShell::ICOMLink::INotification #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MFransen69 merged 4 commits into from
Oct 28, 2025
Merged

[SimpleCOMRPC] Adjust the plugin after changes to IShell::ICOMLink::INotification #936

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a05db8
Change the Revoked and Dangling functionality
VeithMetro Oct 27, 2025
7b32f14
Fix a warning
VeithMetro Oct 28, 2025
a06040c
Merge branch 'master' into development/SimpleCOMRPCPluginServer
VeithMetro Oct 28, 2025
de40145
Merge branch 'master' into development/SimpleCOMRPCPluginServer
MFransen69 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/SimpleCOMRPC/Client/SimpleCOMRPCClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ int main(int argc, char* argv[])
printf("We do not have a clock interface, so we can not get the time\n");
}
else {
printf("The Ticker is at: %llu\n", clock->Now());
printf("The Ticker is at: %lu\n", clock->Now());
}
break;
case 'T':
Expand Down
5 changes: 3 additions & 2 deletions examples/SimpleCOMRPC/PluginServer/SimpleCOMRPCPluginServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,10 @@ namespace Plugin {
return (_parent == nullptr ? 0 : result.Ticks());
}

void SimpleCOMRPCPluginServer::OnRevoke(const Exchange::IWallClock::ICallback* remote) {
void SimpleCOMRPCPluginServer::OnInterfaceDangling(const Exchange::IWallClock::ICallback* remote)
{
// Looks like we need to stop the callback from being called, it is a dead object now anyway :-)
TRACE(Trace::Information, (_T("Revoking a callback, it will not fire anymore")));
TRACE(Trace::Information, (_T("Callback is dangling, disarming it so it will not fire anymore")));
_notifier.Disarm(remote);
}

Expand Down
11 changes: 3 additions & 8 deletions examples/SimpleCOMRPC/PluginServer/SimpleCOMRPCPluginServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,7 @@ namespace Plugin {

void Dangling(const Core::IUnknown* remote, const uint32_t interfaceId) override
{
//not interested in this notification
TRACE(Trace::Information, (_T("Cleanup an interface: %d [%X] on object: [%s]"), interfaceId, interfaceId, typeid(*remote).name()));
}
void Revoked(const Core::IUnknown* remote, const uint32_t interfaceId) override
{
TRACE(Trace::Information, (_T("Revoking an interface: %d [%X] on object: [%s]"), interfaceId, interfaceId, typeid(*remote).name()));
TRACE(Trace::Information, (_T("Dangling interface: %d [%X] on object: [%s]"), interfaceId, interfaceId, typeid(*remote).name()));

// Something happened to the other side
ASSERT(interfaceId != Exchange::ID_WALLCLOCK);
Expand All @@ -98,7 +93,7 @@ namespace Plugin {

ASSERT(result != nullptr);

_parent.OnRevoke(result);
_parent.OnInterfaceDangling(result);

// Do not forget to release the QI from a few lines above :-)
result->Release();
Expand Down Expand Up @@ -304,7 +299,7 @@ POP_WARNING()
virtual string Information() const;

private:
void OnRevoke(const Exchange::IWallClock::ICallback* remote);
void OnInterfaceDangling(const Exchange::IWallClock::ICallback* remote);

private:
WallClockNotifier _notifier;
Expand Down
Loading