Refactor duplicated Rialto discovery logic into reusable CMake function#879
Draft
Copilot wants to merge 2 commits intofeature/VPLAY-12110-simplifiedfrom
Draft
Refactor duplicated Rialto discovery logic into reusable CMake function#879Copilot wants to merge 2 commits intofeature/VPLAY-12110-simplifiedfrom
Copilot wants to merge 2 commits intofeature/VPLAY-12110-simplifiedfrom
Conversation
Co-authored-by: pstroffolino <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issues raised in PR #875 feedback
Refactor duplicated Rialto discovery logic into reusable CMake function
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from PR #875 requesting DRY refactoring of duplicated Rialto discovery logic in
test/rialtoPOC/CMakeLists.txt.Changes
find_and_configure_rialto()function containing Rialto dependency discovery logic (find_path,find_library,find_package_handle_standard_args, imported target creation)rialtoPOC2andrialtoPOC3targets instead of duplicating 40 lines per targetPARENT_SCOPEto allset()calls within the function to propagate variables (RIALTO_LIBRARIES,RIALTO_INCLUDE_DIRS,RIALTO_FOUND) to parent scopeFollows existing CMake function patterns in codebase (
aamp_utest_run_add,xcode_define_schema).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.