-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recurring messages to some channels #124
Conversation
0bbf0ce
to
85b9df8
Compare
85b9df8
to
1ac66a4
Compare
Presume to post in Reactiflux, log to #bot-log, small naming/etc changes, add channel ID and frequency constants
This assumes all timers start on sunday at midnight, and resumes them on startup by scheduling for the next intended run from there
Also removes messageConfig from args and just uses the constant
0672607
to
a2800d3
Compare
bot.on("ready", () => { | ||
MESSAGE_SCHEDULE.forEach((messageConfig) => | ||
sendMessage(bot, messageConfig), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the bug was that I was trying to send messages before the bot logged in, not anything related to permissions/etc 🤦 oh well, we got there
}, | ||
}, | ||
{ | ||
postTo: [{ interval: FREQUENCY.often, channelId: CHANNELS.helpJs }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I see the benefit for the jobBoard and helpReact(moreThanWeekly) channels I don't really see what benefit the helpJs and helpReact(often) brings.
Maybe we should improve the new joiner experience in general? e.g. have a channel with a message explaining all of this visible right after joining and having other channels hidden for like 2 minutes, giving everyone time to read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd quite like to improve the new joiner experience in general, adding some form of onboarding would be awesome — right now we can't control what channel people enter, so I thought repeatedly surfacing info that that's tucked away in channel descriptions was a low-effort way to improve on the current state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always update the welcome screen channels (up to 5 supported).
Closes #124. We've had support for this forever, but have never actually used them! This re-posts rules to
#job-board
every day, and some other messages intended to guide new joiners in our highest traffic channels.