ci(linting): add remaining linting and formatting checks #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronMcClymont
force-pushed
the
add-remaining-linting
branch
from
670318f to
8ff0c9f
Compare
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
======================================
Coverage 0.90% 0.90%
======================================
Files 10 10
Lines 551 551
======================================
Hits 5 5
Misses 546 546 🚀 New features to boost your workflow:
|
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 17, 2025
CameronMcClymont
force-pushed
the
add-remaining-linting
branch
from
8ff0c9f to
c3d1b05
Compare
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 28, 2025
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 28, 2025
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 28, 2025
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 28, 2025
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Jul 28, 2025
CameronMcClymont
force-pushed
the
add-remaining-linting
branch
from
c3d1b05 to
c4bdb49
Compare
tiborsimko
reviewed
Aug 6, 2025
Member
tiborsimko
left a comment
tiborsimko
left a comment
There was a problem hiding this comment.
Thanks, works nicely 👍
Please add yourself to AUTHORS.md.
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Aug 6, 2025
CameronMcClymont
added a commit
to CameronMcClymont/reana-workflow-engine-cwl
that referenced
this pull request
Aug 6, 2025
CameronMcClymont
force-pushed
the
add-remaining-linting
branch
from
c4bdb49 to
e8b55bb
Compare
tiborsimko
reviewed
Aug 12, 2025
| @@ -0,0 +1,4 @@ | |||
| # Allow prompt dollar sign in console examples without showing output | |||
| MD014: false | |||
| # Allow multiple headings with same content (for different releases) | |||
Member
There was a problem hiding this comment.
Cosmetics: Please separate the two rules for better clarity.
CameronMcClymont
force-pushed
the
add-remaining-linting
branch
from
e8b55bb to
4b6dbb7
Compare
tiborsimko
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce remaining file formatting checks to
run-tests.shand to the GitHub CI:.editorconfigfor consistent character formatting across the repoyamllintfor YAML lintingjsonlintfor JSON lintingshfmtfor shell script formattingmarkdownlintfor markdown lintingprettierfor various other formatting such as.jsfilesCloses #300