Skip to content

chore: Deprecate existing Menu #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2025
Merged

chore: Deprecate existing Menu #636

merged 7 commits into from
Jul 24, 2025

Conversation

kurtdoherty
Copy link
Contributor

Context

  • The existing Menu component is partially complete, but has a number of issues related to it (focus outline of items is clipped, menu item prop interface incomplete, inadequate positioning w.r.t anchor, reliant on div container which interferes with the layout of the trigger and more)
  • We need to deliver a more solid foundation for Menu's while also supporting the updated Menu design requirements.
  • To do this, we'll deprecate the existing Menu and implement a new one. This will allow consumers (including other Elements components) to gradually migrate to the new version.

This PR

  • Deprecates Menu and renames it to DeprecatedMenu.

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 24, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty force-pushed the chore-deprecate-menu branch from bfa6464 to 5d8e2f4 Compare July 24, 2025 01:40
@codacy-production Codacy Production
Copy link

codacy-production bot commented Jul 24, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 24213a01 ✅ 91.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (24213a0) Report Missing Report Missing Report Missing
Head commit (255b2d3) 7791 7068 90.72%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#636) 173 158 91.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@kurtdoherty kurtdoherty marked this pull request as ready for review July 24, 2025 01:46
@kurtdoherty kurtdoherty force-pushed the chore-deprecate-menu branch from 5d8e2f4 to 255b2d3 Compare July 24, 2025 01:49
kurtdoherty
kurtdoherty commented Jul 24, 2025
View reviewed changes
package.json
@@ -1,6 +1,6 @@
{
"name": "@reapit/elements",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: forgot to do this after the last release.

src/core/app-switcher/app-switcher.tsx
@@ -7,7 +7,7 @@ import { AppSwitcherYourAppsMenuGroup } from './your-apps-menu-group'
import { ElAppSwitcherSectionDivider } from './styles'
import { getDisplayableProductsForYourAppsGroup } from './get-displayable-products-for-your-apps-group'
import { getDisplayableProductsForExploreGroup } from './get-displayable-products-for-explore-group'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: lots of changes like this...

src/core/dialog/body/styles.ts
@@ -16,7 +15,4 @@ export const ElDialogBody = styled.article`
[data-size='full-screen'] & {
padding: var(--spacing-5);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: CSS lint error. Not sure why it wasn't erroring on this works original builds 🤔

src/core/drawer/constants.ts
@@ -1,4 +1,4 @@
export const DRAWER_CSS_CONTAINER_NAME = 'drawer'
export const DRAWER_CSS_CONTAINER_NAME = '--drawer'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: small scout

src/storybook/changelog.mdx
@@ -16,6 +16,10 @@ We will publish release version history and changes here. Where possible, we wil

Beta versions should be relatively stable but subject to occssional breaking changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: forgot to set this section up after the last release.

stylelint.config.js
@@ -25,7 +25,7 @@ export default {
'at-rule-descriptor-no-unknown': true,
'at-rule-descriptor-value-no-unknown': true,
'at-rule-no-unknown': true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: not sure why these rules weren't having problems when I added the new match media helpers 🤷

@kurtdoherty kurtdoherty merged commit e7f5f1e into main Jul 24, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the chore-deprecate-menu branch July 24, 2025 01:56
This was referenced Jul 24, 2025
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtdoherty @rpt-uk-github