Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storageClusterPeer: add logic for storageclusterpeer controller #2678

Merged
merged 1 commit into from
Nov 11, 2024
Merged

storageClusterPeer: add logic for storageclusterpeer controller #2678

merged 1 commit into from
Nov 11, 2024

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Jul 1, 2024 •
edited
Loading

@rewantsoni
Copy link
Member Author

/retest-required

rchikatw
rchikatw reviewed Jul 8, 2024
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
controllers/util/k8sutil.go Outdated Show resolved Hide resolved
leelavg
leelavg reviewed Jul 16, 2024
View reviewed changes
controllers/util/k8sutil.go Outdated Show resolved Hide resolved
api/v1/storageclusterpeer_types.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
@rewantsoni rewantsoni force-pushed the scp-controller branch 6 times, most recently from c31ebbe to cd4371e Compare July 31, 2024 10:56
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2024
@rewantsoni rewantsoni force-pushed the scp-controller branch 4 times, most recently from 0fe696a to cfbc4bf Compare November 5, 2024 15:03
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2024
@rewantsoni rewantsoni force-pushed the scp-controller branch 2 times, most recently from 44b0276 to dc8a088 Compare November 6, 2024 13:51
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@rewantsoni rewantsoni force-pushed the scp-controller branch 2 times, most recently from 8d456a4 to 99e35e9 Compare November 7, 2024 15:09
nb-ohad
nb-ohad requested changes Nov 7, 2024
View reviewed changes
controllers/storagecluster/reconcile.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the scp-controller branch 5 times, most recently from 44f8993 to ae29829 Compare November 8, 2024 11:27
nb-ohad
nb-ohad requested changes Nov 11, 2024
View reviewed changes
controllers/storagecluster/reconcile.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the scp-controller branch 2 times, most recently from 7430e29 to 0a47707 Compare November 11, 2024 13:55
nb-ohad
nb-ohad requested changes Nov 11, 2024
View reviewed changes
controllers/util/k8sutil.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
nb-ohad
nb-ohad requested changes Nov 11, 2024
View reviewed changes
controllers/storagecluster/reconcile.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the scp-controller branch 3 times, most recently from ca466d4 to d1b15b2 Compare November 11, 2024 14:45
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 199e115 into red-hat-storage:main Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchikatw rchikatw rchikatw left review comments

@leelavg leelavg leelavg left review comments

@nb-ohad nb-ohad nb-ohad requested changes

Assignees

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rewantsoni @nb-ohad @leelavg @rchikatw @openshift-merge-robot