Validator Base Module #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the specific country validators to only use this module
specifying the required documents without having to create a
`validate/2` function for every document.
use Bali.Validator,
country: :pt,
documents: %{
nif: ~r/^\d{9}$/
}
poncho
requested review from
erickgnavar,
ivanAlfonsoVillaVazquez and
CevaMenelao
erickgnavar
reviewed
Feb 10, 2023
|
|
||
| regex -> | ||
| if Regex.match?(regex, value) do | ||
| true |
There was a problem hiding this comment.
Devolver true puede generar confusión porque se puede asumir que en caso contrario se va a devolver false, se podría quedar como :ok 🤔
There was a problem hiding this comment.
Ates regresaba un tipo {:ok, String.t()}. No sería bueno mantenerlo?
There was a problem hiding this comment.
Con lo que se habló en el canal se dejó que se mantenga :valid | {:error, String.t()} como spec de respuesta
CevaMenelao
requested changes
Feb 13, 2023
| como fiscales, segun lo revisado con operaciones | ||
|
|
||
| ## Ejemplos: | ||
| Validator for Portuguese personal and tax identifications.any() |
|
|
||
| regex -> | ||
| if Regex.match?(regex, value) do | ||
| true |
There was a problem hiding this comment.
Ates regresaba un tipo {:ok, String.t()}. No sería bueno mantenerlo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Instead of having to create a function for each different document we need for every country, we added a base module that creates this function for each specified document in the
usecommand.Example