Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Base Module #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions lib/bali/validator.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
defmodule Bali.Validator do
defmacro __using__(opts) do
quote do
uq_opts = unquote(opts)
@valid_docs Keyword.get(uq_opts, :documents, [])
@country Keyword.get(uq_opts, :country, "")

def validate(document_type, value) do
case Map.get(@valid_docs, document_type) do
nil ->
{:error, "Invalid document for country #{@country}"}

regex ->
if Regex.match?(regex, value) do
true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devolver true puede generar confusión porque se puede asumir que en caso contrario se va a devolver false, se podría quedar como :ok 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ates regresaba un tipo {:ok, String.t()}. No sería bueno mantenerlo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Con lo que se habló en el canal se dejó que se mantenga :valid | {:error, String.t()} como spec de respuesta

else
{:error, "Invalid value for #{document_type}"}
end
end
end
end
end
end
45 changes: 9 additions & 36 deletions lib/validators/portugal.ex
Original file line number Diff line number Diff line change
@@ -1,44 +1,17 @@
defmodule Bali.Validators.Portugal do
@moduledoc """
Validador para los identificadores personales y fiscales de Portugal.
Soporta el NIF (Número de identificación fiscal)
"""

@doc """
Valida el formato del NIF
Este identificador se utiliza tanto para documentos personales
como fiscales, segun lo revisado con operaciones

## Ejemplos:
Validator for Portuguese personal and tax identifications.any()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.any() ?


```elixir
## Supported documents:

iex> Bali.Validators.Portugal.validate(:nif, "123456789")
{:ok, "123456789"}
### nif - Número de Identificação Fiscal
CevaMenelao marked this conversation as resolved.
Show resolved Hide resolved
Tax identification number

iex> Bali.Validators.Portugal.validate(:nif, "12345678")
{:error, "NIF inválido"}

```
"""
@spec validate(atom, String.t()) :: {:ok, String.t()} | {:error, String.t()}
def validate(:nif, value) do
if Regex.match?(nif(), value) do
{:ok, value}
else
{:error, "NIF inválido"}
end
end

def validate(_, _) do
{:error, "Tipo de documento inválido"}
end

# Expresión regular para validar el NIF
# Su estructura es un bloque de nueve dígitos:
# ejemplo '999999999'
@spec nif() :: Regex.t()
defp nif do
~r/^\d{9}$/
end
use Bali.Validator,
country: :pt,
documents: %{
nif: ~r/^\d{9}$/
}
end