-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Base Module #14
Open
poncho
wants to merge
2
commits into
master
Choose a base branch
from
poncho/validator-macro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
defmodule Bali.Validator do | ||
defmacro __using__(opts) do | ||
quote do | ||
uq_opts = unquote(opts) | ||
@valid_docs Keyword.get(uq_opts, :documents, []) | ||
@country Keyword.get(uq_opts, :country, "") | ||
|
||
def validate(document_type, value) do | ||
case Map.get(@valid_docs, document_type) do | ||
nil -> | ||
{:error, "Invalid document for country #{@country}"} | ||
|
||
regex -> | ||
if Regex.match?(regex, value) do | ||
true | ||
else | ||
{:error, "Invalid value for #{document_type}"} | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,17 @@ | ||
defmodule Bali.Validators.Portugal do | ||
@moduledoc """ | ||
Validador para los identificadores personales y fiscales de Portugal. | ||
Soporta el NIF (Número de identificación fiscal) | ||
""" | ||
|
||
@doc """ | ||
Valida el formato del NIF | ||
Este identificador se utiliza tanto para documentos personales | ||
como fiscales, segun lo revisado con operaciones | ||
|
||
## Ejemplos: | ||
Validator for Portuguese personal and tax identifications.any() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
```elixir | ||
## Supported documents: | ||
|
||
iex> Bali.Validators.Portugal.validate(:nif, "123456789") | ||
{:ok, "123456789"} | ||
### nif - Número de Identificação Fiscal | ||
CevaMenelao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Tax identification number | ||
|
||
iex> Bali.Validators.Portugal.validate(:nif, "12345678") | ||
{:error, "NIF inválido"} | ||
|
||
``` | ||
""" | ||
@spec validate(atom, String.t()) :: {:ok, String.t()} | {:error, String.t()} | ||
def validate(:nif, value) do | ||
if Regex.match?(nif(), value) do | ||
{:ok, value} | ||
else | ||
{:error, "NIF inválido"} | ||
end | ||
end | ||
|
||
def validate(_, _) do | ||
{:error, "Tipo de documento inválido"} | ||
end | ||
|
||
# Expresión regular para validar el NIF | ||
# Su estructura es un bloque de nueve dígitos: | ||
# ejemplo '999999999' | ||
@spec nif() :: Regex.t() | ||
defp nif do | ||
~r/^\d{9}$/ | ||
end | ||
use Bali.Validator, | ||
country: :pt, | ||
documents: %{ | ||
nif: ~r/^\d{9}$/ | ||
} | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devolver
true
puede generar confusión porque se puede asumir que en caso contrario se va a devolverfalse
, se podría quedar como:ok
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ates regresaba un tipo
{:ok, String.t()}
. No sería bueno mantenerlo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Con lo que se habló en el canal se dejó que se mantenga
:valid | {:error, String.t()}
como spec de respuesta