Fix reversed calloc() arguments #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prototype is "void *calloc(size_t nelem, size_t elsize);" These two instances had them reversed, almost certainly leading to buffer overflow issues. This was detected by -Werror=calloc-transposed-args on gcc. Signed-off-by: Stephen Gallagher <[email protected]>
|
@vathpela Could you have a look at this? The |
|
Really not seeing how this could "almost certainly" (or at all?) lead to buffer overflow issues, but sure, it's wrong and the fix looks fine. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prototype is "void *calloc(size_t nelem, size_t elsize);"
These two instances had them reversed, almost certainly leading to buffer overflow issues. This was detected by
-Werror=calloc-transposed-args on gcc.
Fixes #117