Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svsim with gcc14 #4121

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix svsim with gcc14 #4121

merged 2 commits into from
May 31, 2024

Conversation

Emin017
Copy link
Contributor

@Emin017 Emin017 commented May 31, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Dependency update

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@Emin017
Copy link
Contributor Author

Emin017 commented May 31, 2024

I'm using svsim with the -Werror option in CFLAGS, but I've noticed a change in the way calloc is used in gcc14:https://forums.fedoraforum.org/showthread.php?331882-Latest-gcc-compiler

And this problem is also present in many other open source projects:

Although many chisel users are not using such a high version of gcc, I felt it was important to let people know about this issue

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 31, 2024
@jackkoenig jackkoenig added this to the 5.x milestone May 31, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Funny that so many (present company included obviously) get this backward.

@jackkoenig jackkoenig merged commit 25f70bd into chipsalliance:main May 31, 2024
15 of 16 checks passed
@mergify mergify bot added the Backported This PR has been backported label May 31, 2024
mergify bot pushed a commit that referenced this pull request May 31, 2024
(cherry picked from commit 25f70bd)
@mergify mergify bot mentioned this pull request May 31, 2024
14 tasks
mergify bot pushed a commit that referenced this pull request May 31, 2024
(cherry picked from commit 25f70bd)
@mergify mergify bot mentioned this pull request May 31, 2024
14 tasks
chiselbot pushed a commit that referenced this pull request May 31, 2024
(cherry picked from commit 25f70bd)

Co-authored-by: qimingchu <[email protected]>
chiselbot pushed a commit that referenced this pull request May 31, 2024
(cherry picked from commit 25f70bd)

Co-authored-by: qimingchu <[email protected]>
@Emin017 Emin017 deleted the gcc14 branch June 1, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants