start-ceph: do rm -rf only when path exists #88

nizamial09 · 2024-11-05T13:52:30Z

start-ceph.sh has a line to remove rm -rf "$CEPH_CONF_PATH"/* If someone run this script locally when he has root previllages, he could accidentally remove his / directory because CEPH_CONF_PATH will come empty and the command will become rm -rf /* which is like shooting yourself infinitely..

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

🚫 [shellcheck] _{reported by reviewdog 🐶}
Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @). SC2199

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 62 in fccae8d

if [[ -n "$@" ]]; then

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 108 in fccae8d

TOX_ARGS="$@"

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 116 in fccae8d

if [[ "$(tox -l | grep cov | wc -l)" > 0 ]]; then # Nautilus branch.

🚫 [shellcheck] _{reported by reviewdog 🐶}
> is for string comparisons. Use -gt instead. SC2071

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 116 in fccae8d

if [[ "$(tox -l | grep cov | wc -l)" > 0 ]]; then # Nautilus branch.

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 125 in fccae8d

tox ${TOX_OPTIONS} $TOX_ARGS

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 147 in fccae8d

local grafonnet_version=$(grep 'set(ver' CMakeLists.txt | grep -Eo "([0-9.])+")

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 181 in fccae8d

MYPY_ARGS="$@"

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 186 in fccae8d

    
               mypy --config-file="$MYPY_CONFIG_FILE" --cache-dir=src/.mypy_cache --follow-imports=skip ${MYPY_ARGS}

📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: ./run-backend-api-tests.sh: openBinaryFile: does not exist (No such file or directory) SC1091

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 228 in fccae8d

source ./run-backend-api-tests.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 255 in fccae8d

E2E_CMD="npx cypress run $@ --browser chrome --headless"

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 256 in fccae8d

elif [[ "$(npm run | grep e2e:ci | wc -l)" == 1 ]]; then

📝 [shellcheck] _{reported by reviewdog 🐶}
Consider using pgrep instead of grepping ps output. SC2009

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 261 in fccae8d

if [[ $(ps -ef | grep -v grep | grep "ceph-mgr -i" | wc -l) == 0 ]]; then

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 261 in fccae8d

if [[ $(ps -ef | grep -v grep | grep "ceph-mgr -i" | wc -l) == 0 ]]; then

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 270 in fccae8d

export DASHBOARD_URL=$("$CEPH_BIN"/ceph mgr services | jq -r .dashboard)

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 286 in fccae8d

${E2E_CMD} -- ${ARGS}

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 314 in fccae8d

return 2> /dev/null || true

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 317 in fccae8d

"${@}"

github-actions · 2024-11-05T13:53:23Z

docker/ceph/start-ceph.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: /docker/set-start-env.sh: openBinaryFile: does not exist (No such file or directory) SC1091

ceph-dev/docker/ceph/start-ceph.sh

Line 5 in fccae8d

source /docker/set-start-env.sh

github-actions · 2024-11-05T13:53:24Z

docker/ceph/start-ceph.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
The surrounding quotes actually unquote this. Remove or escape them. SC2027

ceph-dev/docker/ceph/start-ceph.sh

Line 14 in fccae8d

jq "(.[] | .target)=\""${TARGET_URL}"\"" proxy.conf.json.sample > proxy.conf.json

github-actions · 2024-11-05T13:53:24Z

docker/ceph/start-ceph.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/start-ceph.sh

Line 14 in fccae8d

jq "(.[] | .target)=\""${TARGET_URL}"\"" proxy.conf.json.sample > proxy.conf.json

github-actions · 2024-11-05T13:53:28Z

docker/ceph/ci/sanity-checks.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 30 in fccae8d

local TARGET="$@"

github-actions · 2024-11-05T13:53:29Z

docker/ceph/ci/sanity-checks.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 32 in fccae8d

local CONSOLE_CALLS=$((echo "${TARGET}" | xargs grep -Eirn "console\..*\(") || echo '')

github-actions · 2024-11-05T13:53:30Z

docker/ceph/ci/sanity-checks.sh

🚫 [shellcheck] _{reported by reviewdog 🐶}
Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors. SC1102

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 32 in fccae8d

local CONSOLE_CALLS=$((echo "${TARGET}" | xargs grep -Eirn "console\..*\(") || echo '')

nizamial09 · 2024-11-05T13:54:03Z

an example inside a container..

[root@8c015bb5eb48 ceph]# cd ceph-dev/docker/ceph
bash: cd: ceph-dev/docker/ceph: No such file or directory
[root@8c015bb5eb48 ceph]# ./start-ceph.sh
set-start-env.sh: line 10: hostname: command not found
rm: cannot remove '/ceph-dev': Device or resource busy
rm: cannot remove '/dev/pts/0': Operation not permitted
rm: cannot remove '/dev/pts/ptmx': Operation not permitted
rm: cannot remove '/dev/mqueue': Device or resource busy
rm: cannot remove '/dev/shm': Device or resource busy
rm: cannot remove '/dev/console': Device or resource busy
rm: cannot remove '/etc/hostname': Device or resource busy
rm: cannot remove '/etc/hosts': Device or resource busy
rm: cannot remove '/etc/resolv.conf': Device or resource busy
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/fc_info': Read-only file system
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/options': Read-only file system
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/mb_stats': Read-only file system
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/mb_groups': Read-only file system
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/es_shrinker_info': Read-only file system
rm: cannot remove '/proc/fs/ext4/nvme0n1p2/mb_structs_summary': Read-only file system
rm: cannot remove '/proc/fs/jbd2/nvme0n1p2-8/info': Read-only file system
rm: cannot remove '/proc/fs/nfsd': Read-only file system

start-ceph has a line to remove `rm -rf "$CEPH_CONF_PATH"/*` If someone run this script locally when he has root previllages, he could accidentally remove his `/` directory because `CEPH_CONF_PATH` will come empty and the command will become `rm -rf /*` which is like shooting yourself infinitely.. Signed-off-by: Nizamudeen A <[email protected]>

nizamial09 · 2024-11-05T14:00:28Z

bot educated me about https://github.com/koalaman/shellcheck/wiki/SC2115, so going with it.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 181 in ebd2c1c

MYPY_ARGS="$@"

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 186 in ebd2c1c

    
               mypy --config-file="$MYPY_CONFIG_FILE" --cache-dir=src/.mypy_cache --follow-imports=skip ${MYPY_ARGS}

📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: ./run-backend-api-tests.sh: openBinaryFile: does not exist (No such file or directory) SC1091

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 225 in ebd2c1c

source ./run-backend-api-tests.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 252 in ebd2c1c

E2E_CMD="npx cypress run $@ --browser chrome --headless"

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 253 in ebd2c1c

elif [[ "$(npm run | grep e2e:ci | wc -l)" == 1 ]]; then

📝 [shellcheck] _{reported by reviewdog 🐶}
Consider using pgrep instead of grepping ps output. SC2009

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 258 in ebd2c1c

if [[ $(ps -ef | grep -v grep | grep "ceph-mgr -i" | wc -l) == 0 ]]; then

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 258 in ebd2c1c

if [[ $(ps -ef | grep -v grep | grep "ceph-mgr -i" | wc -l) == 0 ]]; then

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 267 in ebd2c1c

export DASHBOARD_URL=$("$CEPH_BIN"/ceph mgr services | jq -r .dashboard)

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 283 in ebd2c1c

${E2E_CMD} -- ${ARGS}

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 311 in ebd2c1c

return 2> /dev/null || true

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 314 in ebd2c1c

"${@}"

github-actions · 2024-11-05T14:00:55Z

docker/ceph/start-ceph.sh

@@ -45,7 +45,7 @@ if [[ -n "${DASHBOARD_URL}" ]]; then
    exit 0
 fi

-rm -rf "$CEPH_CONF_PATH"/*
+rm -rf "${CEPH_CONF_PATH:?}"/*

 cd /ceph/build
 ../src/vstart.sh ${VSTART_OPTIONS}


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2024-11-05T14:00:56Z

docker/ceph/start-ceph.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/start-ceph.sh

Line 75 in ebd2c1c

readonly VSTART_HAS_SSL_FLAG=$(cat /ceph/src/vstart.sh | grep DASHBOARD_SSL | wc -l)

github-actions · 2024-11-05T14:00:57Z

docker/ceph/start-ceph.sh

[shellcheck] _{reported by reviewdog 🐶}
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. SC2002

ceph-dev/docker/ceph/start-ceph.sh

Line 75 in ebd2c1c

readonly VSTART_HAS_SSL_FLAG=$(cat /ceph/src/vstart.sh | grep DASHBOARD_SSL | wc -l)

github-actions · 2024-11-05T14:00:57Z

docker/ceph/start-ceph.sh

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/start-ceph.sh

Line 75 in ebd2c1c

readonly VSTART_HAS_SSL_FLAG=$(cat /ceph/src/vstart.sh | grep DASHBOARD_SSL | wc -l)

github-actions · 2024-11-05T14:00:58Z

docker/ceph/start-ceph.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Possible misspelling: DASHBOARD_SSL may not be assigned. Did you mean DASHBOARD_URL? SC2153

ceph-dev/docker/ceph/start-ceph.sh

Line 76 in ebd2c1c

if [[ "$DASHBOARD_SSL" == 0 && "$VSTART_HAS_SSL_FLAG" == 0 ]]; then

github-actions · 2024-11-05T14:01:00Z

docker/ceph/ci/sanity-checks.sh

🚫 [shellcheck] _{reported by reviewdog 🐶}
Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @). SC2199

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 62 in ebd2c1c

if [[ -n "$@" ]]; then

github-actions · 2024-11-05T14:01:01Z

docker/ceph/ci/sanity-checks.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. SC2124

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 108 in ebd2c1c

TOX_ARGS="$@"

github-actions · 2024-11-05T14:01:02Z

docker/ceph/ci/sanity-checks.sh

[shellcheck] _{reported by reviewdog 🐶}
Consider using 'grep -c' instead of 'grep|wc -l'. SC2126

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 116 in ebd2c1c

if [[ "$(tox -l | grep cov | wc -l)" > 0 ]]; then # Nautilus branch.

github-actions · 2024-11-05T14:01:03Z

docker/ceph/ci/sanity-checks.sh

🚫 [shellcheck] _{reported by reviewdog 🐶}
> is for string comparisons. Use -gt instead. SC2071

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 116 in ebd2c1c

if [[ "$(tox -l | grep cov | wc -l)" > 0 ]]; then # Nautilus branch.

github-actions · 2024-11-05T14:01:04Z

docker/ceph/ci/sanity-checks.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 125 in ebd2c1c

tox ${TOX_OPTIONS} $TOX_ARGS

github-actions · 2024-11-05T14:01:05Z

docker/ceph/ci/sanity-checks.sh

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

ceph-dev/docker/ceph/ci/sanity-checks.sh

Line 147 in ebd2c1c

local grafonnet_version=$(grep 'set(ver' CMakeLists.txt | grep -Eo "([0-9.])+")

nizamial09 requested review from cloudbehl and afreen23 November 5, 2024 13:52

github-actions bot reviewed Nov 5, 2024

View reviewed changes

nizamial09 force-pushed the recursive-rm-fix branch from fccae8d to ebd2c1c Compare November 5, 2024 13:59

github-actions bot reviewed Nov 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

start-ceph: do rm -rf only when path exists #88

start-ceph: do rm -rf only when path exists #88

nizamial09 commented Nov 5, 2024

github-actions bot left a comment

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

nizamial09 commented Nov 5, 2024

nizamial09 commented Nov 5, 2024

github-actions bot left a comment

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

start-ceph: do rm -rf only when path exists #88

Are you sure you want to change the base?

start-ceph: do rm -rf only when path exists #88

Conversation

nizamial09 commented Nov 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

nizamial09 commented Nov 5, 2024

nizamial09 commented Nov 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment