Skip to content

fix: expand numpy compat range to >=1.26 #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 5, 2025
Merged

Conversation

jselig-rigetti
Copy link
Contributor

Replaces #1821

@jselig-rigetti jselig-rigetti requested a review from a team as a code owner May 1, 2025 20:31
Copy link

github-actions bot commented May 1, 2025

🐰 Bencher Report

Branchnumpy-2.0-compat
Testbedci-runner-linux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencyseconds (s)
test/benchmarks/test_program.py::test_copy_everything_except_instructions📈 view plot
⚠️ NO THRESHOLD
10.63 s
test/benchmarks/test_program.py::test_instructions📈 view plot
⚠️ NO THRESHOLD
4.19 s
test/benchmarks/test_program.py::test_iteration📈 view plot
⚠️ NO THRESHOLD
4.27 s
🐰 View full continuous benchmarking report in Bencher

@the-iron-ryan
Copy link

Hey @jselig-rigetti. Do you have an estimated timeframe for when this upgrade will be done? It's blocking one of the compiler optimizations we're working on for our pre-processing and post-processing integration with you guys.

@jselig-rigetti
Copy link
Contributor Author

Hey @jselig-rigetti. Do you have an estimated timeframe for when this upgrade will be done? It's blocking one of the compiler optimizations we're working on for our pre-processing and post-processing integration with you guys.

@the-iron-ryan it's my top priority now, so working to have a solution by EOD. If that's not possible, I'll alert you as soon as I can. Thank you.

Copy link

github-actions bot commented May 2, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7308 6421 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/noise_gates.py 86% 🟢
pyquil/quilatom.py 83% 🟢
TOTAL 85% 🟢

updated for commit: 3c557ef by action🐍

@jselig-rigetti jselig-rigetti changed the title fix: expand numpy compat range to >=1.25 fix: expand numpy compat range to >=1.26 May 2, 2025
@jselig-rigetti
Copy link
Contributor Author

@the-iron-ryan I'm still looking to merge today pending an approving review, but you can go with this RC release for now if you are blocked: https://pypi.org/project/pyquil/4.16.2rc2/

@jselig-rigetti jselig-rigetti mentioned this pull request May 2, 2025
8 tasks
@the-iron-ryan
Copy link

@the-iron-ryan I'm still looking to merge today pending an approving review, but you can go with this RC release for now if you are blocked: https://pypi.org/project/pyquil/4.16.2rc2/

Perfect! Thanks for quick turn around here @jselig-rigetti. We just found a work-around method to still push our Rigetti embedded package independently without needing to bump numpy. We'll resort to using this rc version instead if all else fails

@jselig-rigetti jselig-rigetti merged commit 4efae89 into master May 5, 2025
3 of 4 checks passed
@jselig-rigetti jselig-rigetti deleted the numpy-2.0-compat branch May 5, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants