Add more details in the specification #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_Float16` is defined as type for the IEEE 16-bit floating-point type. The type was previously `float16_t` and our intent was to try define it under a RISC-V header. However this is not needed since now both the two main upstream compiler (LLVM, GCC) supports this. Signed-off-by: eop Chen <[email protected]>
Using `long` introduces ambiguity to rely on the architecture specified (rv32/rv64). This is unnecessary since it is likely to be impossible for a vector length to exceed the value range of an `int`. Signed-off-by: eop Chen <[email protected]>
Signed-off-by: eop Chen <[email protected]>
eopXD
changed the title
rofirrim
approved these changes
Oct 24, 2023
dzaima
reviewed
Oct 24, 2023
topperc
reviewed
Oct 24, 2023
dzaima
approved these changes
Oct 25, 2023
|
@topperc recently noticed that return value for the
FP16 is not relevant to those two issues, and the change made in this PR was not the agreed-upon solution to those issues. (I don't know if we had even come to a consensus: I had argued for a different solution altogether.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While cleaning up the issue threads, I found some more details we need to have in the specification.
This PR:
=) in the C language" under the programming note section of the specfloat16_twith_Float16that is now supported by both LLVM and GCC. This keeps us away from the need to define our own type. (Resolves Use fixed-width integer type instead of long? #31, and alongside also resolves Should vcpop.m return type be size_t? #166.vlenbutility functionnew_vlargument in fault-only-first load intrinsics