benchmarks: Various fixes for compiling with Clang#225
Open
jrtc27 wants to merge 3 commits intoriscv-software-src:masterfrom
Open
benchmarks: Various fixes for compiling with Clang#225jrtc27 wants to merge 3 commits intoriscv-software-src:masterfrom
jrtc27 wants to merge 3 commits intoriscv-software-src:masterfrom
Conversation
It's unnecessary and non-portable; Clang doesn't even implement that part of GNU C.
Clang's driver does not seem to forward this on, unlike GCC's, so instead ensure the linker sees it by using -Wl.
Clang only supports register variables when declared at global scope (and only for non-allocatable registers, which is fine for tp), so move thread_pointer. This does not make thread_pointer visible outside the translation unit, it merely acts as a C alias for tp, so the semantics remain unchanged.
Contributor
Author
|
Ping? |
aswaterman
approved these changes
Feb 12, 2020
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the merge conflict?
Closed
|
Bump, we are STILL seeing the nested function definition error three years later! |
Collaborator
|
There's a merge conflict, so I can't merge it. Please contact the original author so they can fix it, or submit a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.