[io] Replace hardcoded 0644 permissions with 0666 to respect umask #20499
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the system umask to control file permissions instead of hardcoding them to 0644. Files will now be created with permissions determined by (0666 & ~umask), which is the standard Unix behavior. Files modified: - io/io/src/TFile.cxx - io/io/src/TMapFile.cxx - io/io/src/TMemFile.cxx - io/dcache/src/TDCacheFile.cxx - net/net/src/TFTP.cxx - net/net/src/TApplicationServer.cxx Fixes root-project#17095
Collaborator
Contributor
Author
Test Results 22 files 22 suites 3d 22h 5m 4s ⏱️ Results for commit fed7ac7. |
Member
|
Added two Linux and experts as reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes or fixes:
Replace hardcoded 0644 file permissions with 0666 to respect system umask.
This change allows the system umask to control file permissions instead of hardcoding them to 0644. Files will now be created with permissions determined by (0666 & ~umask), which is the standard Unix behavior.
Files modified:
io/io/src/TFile.cxxio/io/src/TMapFile.cxxio/io/src/TMemFile.cxxio/dcache/src/TDCacheFile.cxxnet/net/src/TFTP.cxxnet/net/src/TApplicationServer.cxxChecklist:
This PR fixes #20470