Skip to content

[io] Replace hardcoded 0644 permissions with 0666 to respect umask #20499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −11
Open

[io] Replace hardcoded 0644 permissions with 0666 to respect umask #20499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions io/dcache/src/TDCacheFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ TDCacheFile::TDCacheFile(const char *path, Option_t *option,

if (create || update) {
#ifndef WIN32
fD = SysOpen(fname, O_RDWR | O_CREAT, 0644);
fD = SysOpen(fname, O_RDWR | O_CREAT, 0666);
#else
fD = SysOpen(fname, O_RDWR | O_CREAT | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand All @@ -151,7 +151,7 @@ TDCacheFile::TDCacheFile(const char *path, Option_t *option,
fWritable = kTRUE;
} else {
#ifndef WIN32
fD = SysOpen(fname, O_RDONLY, 0644);
fD = SysOpen(fname, O_RDONLY, 0666);
#else
fD = SysOpen(fname, O_RDONLY | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand Down
8 changes: 4 additions & 4 deletions io/io/src/TFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ TFile::TFile(const char *fname1, Option_t *option, const char *ftitle, Int_t com
// Connect to file system stream
if (create || update) {
#ifndef WIN32
fD = TFile::SysOpen(fname.Data(), O_RDWR | O_CREAT, 0644);
fD = TFile::SysOpen(fname.Data(), O_RDWR | O_CREAT, 0666);
#else
fD = TFile::SysOpen(fname.Data(), O_RDWR | O_CREAT | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand All @@ -545,7 +545,7 @@ TFile::TFile(const char *fname1, Option_t *option, const char *ftitle, Int_t com
fWritable = kTRUE;
} else {
#ifndef WIN32
fD = TFile::SysOpen(fname.Data(), O_RDONLY, 0644);
fD = TFile::SysOpen(fname.Data(), O_RDONLY, 0666);
#else
fD = TFile::SysOpen(fname.Data(), O_RDONLY | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand Down Expand Up @@ -2236,7 +2236,7 @@ Int_t TFile::ReOpen(Option_t *mode)
// open in READ mode
fOption = opt; // set fOption before SysOpen() for TNetFile
#ifndef WIN32
fD = SysOpen(fRealName, O_RDONLY, 0644);
fD = SysOpen(fRealName, O_RDONLY, 0666);
#else
fD = SysOpen(fRealName, O_RDONLY | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand All @@ -2258,7 +2258,7 @@ Int_t TFile::ReOpen(Option_t *mode)
// open in UPDATE mode
fOption = opt; // set fOption before SysOpen() for TNetFile
#ifndef WIN32
fD = SysOpen(fRealName, O_RDWR | O_CREAT, 0644);
fD = SysOpen(fRealName, O_RDWR | O_CREAT, 0666);
#else
fD = SysOpen(fRealName, O_RDWR | O_CREAT | O_BINARY, S_IREAD | S_IWRITE);
#endif
Expand Down
2 changes: 1 addition & 1 deletion io/io/src/TMapFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ TMapFile::TMapFile(const char *name, const char *title, Option_t *option,
// Open file to which memory will be mapped
if (create || update) {
#ifndef WIN32
fFd = open(fname, O_RDWR | O_CREAT, 0644);
fFd = open(fname, O_RDWR | O_CREAT, 0666);
#else
fFd = (Longptr_t) CreateFile(fname, // pointer to name of the file
GENERIC_WRITE | GENERIC_READ, // access (read-write) mode
Expand Down
4 changes: 2 additions & 2 deletions io/io/src/TMemFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,15 @@ TMemFile::TMemFile(const char *path, char *buffer, Long64_t size, Option_t *opti
Int_t mode = O_RDWR | O_CREAT;
if (optmode == EMode::kRecreate) mode |= O_TRUNC;

fD = TMemFile::SysOpen(path, mode, 0644);
fD = TMemFile::SysOpen(path, mode, 0666);
if (fD == -1) {
SysError("TMemFile", "file %s can not be opened", path);
goto zombie;
}
fWritable = kTRUE;

} else {
fD = TMemFile::SysOpen(path, O_RDONLY, 0644);
fD = TMemFile::SysOpen(path, O_RDONLY, 0666);
if (fD == -1) {
SysError("TMemFile", "file %s can not be opened for reading", path);
goto zombie;
Expand Down
2 changes: 1 addition & 1 deletion net/net/src/TApplicationServer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ Int_t TApplicationServer::ReceiveFile(const char *file, Bool_t bin, Long64_t siz

close(fd);

chmod(file, 0644);
chmod(file, 0666);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion net/net/src/TFTP.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ Long64_t TFTP::GetFile(const char *file, const char *localName)
delete [] buf; delete [] buf2;

#ifndef R__WIN32
fchmod(fd, 0644);
fchmod(fd, 0666);
#endif

close(fd);
Expand Down
Loading