-
Notifications
You must be signed in to change notification settings - Fork 34
Add describe_check function #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 50.45% 51.35% +0.89%
==========================================
Files 10 10
Lines 220 222 +2
==========================================
+ Hits 111 114 +3
+ Misses 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a snapshot test for one of the most stable checks?
Writing the comments made me wonder whether there should be some flagging of non-specific-enough expectations for packages that use testthat.
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
Done, as snapshot of |
|
Thank you! I updated the NEWS too |
Not sure who's maintaining this package these days, but ... All tests have a "description" item which is not exposed to the users at all. This function simply does that, which I think is really useful.