Skip to content

Conversation

@mpadge
Copy link
Member

@mpadge mpadge commented Sep 13, 2021

Not sure who's maintaining this package these days, but ... All tests have a "description" item which is not exposed to the users at all. This function simply does that, which I think is really useful.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (564db1f) to head (88fcc1c).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   50.45%   51.35%   +0.89%     
==========================================
  Files          10       10              
  Lines         220      222       +2     
==========================================
+ Hits          111      114       +3     
+ Misses        109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpadge mpadge requested a review from maelle June 23, 2025 09:54
Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a snapshot test for one of the most stable checks?

Writing the comments made me wonder whether there should be some flagging of non-specific-enough expectations for packages that use testthat.

mpadge and others added 22 commits June 24, 2025 09:41
Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Maëlle Salmon <[email protected]>
@mpadge mpadge requested a review from maelle June 24, 2025 11:09
@mpadge
Copy link
Member Author

mpadge commented Jun 24, 2025

Maybe add a snapshot test for one of the most stable checks?

Done, as snapshot of describe_check(all_checks(), which I think will be useful, in spite of needing updating every time the list of checks changes.

@mpadge mpadge merged commit 4a22174 into ropensci-review-tools:main Jul 1, 2025
6 checks passed
@mpadge
Copy link
Member Author

mpadge commented Jul 1, 2025

Thank you! I updated the NEWS too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants