-
Notifications
You must be signed in to change notification settings - Fork 34
Add describe_check function #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
e224556
add describe_check function
mpadge cc691f7
default check_name = NULL
mpadge 947fd54
add test-describe-check
mpadge 7827a26
Merge branch 'ropensci-review-tools:main' into main
mpadge 75f801f
Update R/lists.R
mpadge cad8903
rm spaceout style
mpadge 138c818
Update tests/testthat/test-describe-check.R
mpadge 28fda32
Update tests/testthat/test-describe-check.R
mpadge 2a3f916
Update tests/testthat/test-describe-check.R
mpadge 61f3b7f
Update tests/testthat/test-describe-check.R
mpadge 697b045
Update tests/testthat/test-describe-check.R
mpadge 34e5593
improve test-describe-check
mpadge 6c6447f
add param desc for check_name
mpadge 94ac6ca
test describe_check against all_checks()
mpadge 1823a50
add contributing.md to Rbuildignore
mpadge faabf0d
mv contributing to .github
mpadge c70793e
update contributing url to docs.ropensci
mpadge 2202c69
add describe_check function
mpadge e1eb6b1
default check_name = NULL
mpadge b1668c3
add test-describe-check
mpadge db5aa5d
Update R/lists.R
mpadge cf04b02
rm spaceout style
mpadge d594346
Update tests/testthat/test-describe-check.R
mpadge f4c2b3f
Update tests/testthat/test-describe-check.R
mpadge 2d758ae
Update tests/testthat/test-describe-check.R
mpadge f71c165
Update tests/testthat/test-describe-check.R
mpadge cf32aea
Update tests/testthat/test-describe-check.R
mpadge c3e4dbe
improve test-describe-check
mpadge 191f9c7
add param desc for check_name
mpadge 8f8686e
test describe_check against all_checks()
mpadge 731408d
Merge branch 'ropensci-review-tools-main'
mpadge 0ea1958
add snapshot test for describing all checks
mpadge 88fcc1c
update news with #152
mpadge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
|
|
||
| context("describe check") | ||
|
|
||
| test_that("describe_check", { | ||
| expect_length(describe_check(), 0L) | ||
| chk <- "rcmdcheck_non_portable_makevars" | ||
| d <- describe_check(chk) | ||
| expect_is(d, "list") | ||
| expect_equal(length(d), length(chk)) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect_identical(chk, names(d)) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| chk <- c("no_description_depends", | ||
| "lintr_assignment_linter", | ||
| "no_import_package_as_a_whole", | ||
| "rcmdcheck_missing_docs") | ||
| d <- describe_check(chk) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect_is(d, "list") | ||
| expect_true(length(d) == length(chk)) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect_true(identical(chk, names(d))) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| chk <- c(chk, "a", "b") # "a", "b" are not checks, so ignored | ||
| d <- describe_check(chk) | ||
| expect_is(d, "list") | ||
| expect_false(length(d) == length(chk)) | ||
| expect_false(identical(chk, names(d))) | ||
| expect_true(length(d) < length(chk)) | ||
mpadge marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.