Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e224556
add describe_check function
mpadge Sep 13, 2021
cc691f7
default check_name = NULL
mpadge Sep 13, 2021
947fd54
add test-describe-check
mpadge Sep 13, 2021
7827a26
Merge branch 'ropensci-review-tools:main' into main
mpadge Jun 23, 2025
75f801f
Update R/lists.R
mpadge Jun 24, 2025
cad8903
rm spaceout style
mpadge Jun 24, 2025
138c818
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
28fda32
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
2a3f916
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
61f3b7f
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
697b045
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
34e5593
improve test-describe-check
mpadge Jun 24, 2025
6c6447f
add param desc for check_name
mpadge Jun 24, 2025
94ac6ca
test describe_check against all_checks()
mpadge Jun 24, 2025
1823a50
add contributing.md to Rbuildignore
mpadge Jun 24, 2025
faabf0d
mv contributing to .github
mpadge Jun 24, 2025
c70793e
update contributing url to docs.ropensci
mpadge Jun 24, 2025
2202c69
add describe_check function
mpadge Sep 13, 2021
e1eb6b1
default check_name = NULL
mpadge Sep 13, 2021
b1668c3
add test-describe-check
mpadge Sep 13, 2021
db5aa5d
Update R/lists.R
mpadge Jun 24, 2025
cf04b02
rm spaceout style
mpadge Jun 24, 2025
d594346
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
f4c2b3f
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
2d758ae
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
f71c165
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
cf32aea
Update tests/testthat/test-describe-check.R
mpadge Jun 24, 2025
c3e4dbe
improve test-describe-check
mpadge Jun 24, 2025
191f9c7
add param desc for check_name
mpadge Jun 24, 2025
8f8686e
test describe_check against all_checks()
mpadge Jun 24, 2025
731408d
Merge branch 'ropensci-review-tools-main'
mpadge Jun 24, 2025
0ea1958
add snapshot test for describing all checks
mpadge Jun 24, 2025
88fcc1c
update news with #152
mpadge Jul 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
S3method(print,goodPractice)
export(all_checks)
export(checks)
export(describe_check)
export(export_json)
export(failed_checks)
export(failed_positions)
Expand Down
17 changes: 17 additions & 0 deletions R/lists.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,20 @@ CHECKS <- list()
all_checks <- function() {
names(CHECKS)
}

#' Describe one or more checks
#'
#' @return List of character descriptions for each \code{check_name}
#' @export
#' @examples
#' describe_check("rcmdcheck_non_portable_makevars")
#' check_name <- c ("no_description_depends",
#' "lintr_assignment_linter",
#' "no_import_package_as_a_whole",
#' "rcmdcheck_missing_docs")
#' describe_check(check_name)

describe_check <- function(check_name = NULL) {
check_name <- check_name[check_name %in% names(CHECKS)]
lapply(CHECKS[check_name], function(i) i$description)
}
22 changes: 22 additions & 0 deletions man/describe_check.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions tests/testthat/test-describe-check.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@

context("describe check")

test_that("describe_check", {
expect_length(describe_check(), 0L)
chk <- "rcmdcheck_non_portable_makevars"
d <- describe_check(chk)
expect_is(d, "list")
expect_equal(length(d), length(chk))
expect_identical(chk, names(d))

chk <- c("no_description_depends",
"lintr_assignment_linter",
"no_import_package_as_a_whole",
"rcmdcheck_missing_docs")
d <- describe_check(chk)
expect_is(d, "list")
expect_true(length(d) == length(chk))
expect_true(identical(chk, names(d)))

chk <- c(chk, "a", "b") # "a", "b" are not checks, so ignored
d <- describe_check(chk)
expect_is(d, "list")
expect_false(length(d) == length(chk))
expect_false(identical(chk, names(d)))
expect_true(length(d) < length(chk))
})
Loading