Fix control_filters tests#261
Merged
christophfroehlich merged 3 commits intoros2-masterfrom Jan 4, 2025
Merged
Conversation
b9af6de to
ee7d183
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #261 +/- ##
===============================================
- Coverage 75.15% 74.70% -0.46%
===============================================
Files 26 24 -2
Lines 1131 1099 -32
Branches 89 86 -3
===============================================
- Hits 850 821 -29
Misses 231 231
+ Partials 50 47 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ee7d183 to
5806a32
Compare
saikishor
reviewed
Jan 4, 2025
saikishor
approved these changes
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem of #234 was that the executor in the separate thread sometimes just doesn't stop spinning, and the
join()method hangs. But with these tests, we don't need a spinning node (we just use the parameter and logging interface).To simplify things, I moved that to a common test_fixture.