Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control_filters tests #261

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jan 4, 2025

The problem of #234 was that the executor in the separate thread sometimes just doesn't stop spinning, and the join() method hangs. But with these tests, we don't need a spinning node (we just use the parameter and logging interface).

To simplify things, I moved that to a common test_fixture.

@christophfroehlich christophfroehlich changed the title Fix/filter/tests Fix control_filters tests Jan 4, 2025
@christophfroehlich christophfroehlich marked this pull request as ready for review January 4, 2025 17:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (f0d4400) to head (7692600).
Report is 1 commits behind head on ros2-master.

Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #261      +/-   ##
===============================================
- Coverage        75.15%   74.70%   -0.46%     
===============================================
  Files               26       24       -2     
  Lines             1131     1099      -32     
  Branches            89       86       -3     
===============================================
- Hits               850      821      -29     
  Misses             231      231              
+ Partials            50       47       -3     
Flag Coverage Δ
unittests 74.70% <100.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/control_filters/test_exponential_filter.cpp 100.00% <100.00%> (ø)
test/control_filters/test_filter_util.hpp 100.00% <100.00%> (ø)
test/control_filters/test_low_pass_filter.cpp 100.00% <100.00%> (ø)
test/control_filters/test_rate_limiter.cpp 100.00% <100.00%> (ø)

@christophfroehlich christophfroehlich merged commit e7049ab into ros2-master Jan 4, 2025
27 checks passed
@christophfroehlich christophfroehlich deleted the fix/filter/tests branch January 4, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestLowPassFilterThrowsUnconfigured times out from time to time
3 participants