This repository was archived by the owner on Mar 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I tested this with the pendulum from #172, it is working again!
ahcorde
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any plans to port this to gz_ros_control
? If you don't have time, I can do it
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit 5dba0f9)
This was referenced Oct 4, 2023
ahcorde
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit 5dba0f9) Co-authored-by: Johannes Huemer <[email protected]>
I will have to set up / convert an example with passive joint for gz_sim, but I can do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #235 and #219, a problem with passive joints was introduced by the following code line:
gazebo_ros2_control/gazebo_ros2_control/src/gazebo_system.cpp
Lines 597 to 600 in 0dc19ab
As suggested by @destogl, I added a vector with flags which indicates if a joint is active (has command interfaces) or passive and subsequently sets the velocity to zero or not.