Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 9, 2026

This introduces the fix for the case when the make_controller_exported_state_interfaces_available is called multiple times by the controller manager. This became an issue after merging #2902. We will add tests to this part sooner.


This is an automatic backport of pull request #2951 done by Mergify.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (9fde1e3) to head (9a625c4).
⚠️ Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 85.71% 0 Missing and 2 partials ⚠️
...t_controllers_chaining_with_controller_manager.cpp 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2954      +/-   ##
==========================================
- Coverage   89.33%   89.33%   -0.01%     
==========================================
  Files         157      157              
  Lines       18630    18664      +34     
  Branches     1490     1492       +2     
==========================================
+ Hits        16644    16674      +30     
- Misses       1383     1385       +2     
- Partials      603      605       +2     
Flag Coverage Δ
unittests 89.33% <91.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 74.12% <100.00%> (-0.19%) ⬇️
controller_manager/src/controller_manager.cpp 77.19% <85.71%> (+0.02%) ⬆️
...t_controllers_chaining_with_controller_manager.cpp 99.00% <93.54%> (-0.26%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@destogl destogl merged commit d96f117 into jazzy Jan 9, 2026
14 checks passed
@destogl destogl deleted the mergify/bp/jazzy/pr-2951 branch January 9, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants