Skip to content

Add timestamp to TwistStamped msg (backport #828) #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 10, 2025

Main changes
When following the steps for example_11, I observed lot of warnings logged to the console due to missing timestamps in the header of the TwistStamped message.

This PR updates the instructions and modifies the relevant examples to include timestamps in the TwistStamped message and eliminates the warnings.

[ros2_control_node-1] [WARN] [1749236154.127088701] [bicycle_steering_controller]: Timestamp in header is missing, using current time as command timestamp.
[ros2_control_node-1] [WARN] [1749236154.160455387] [bicycle_steering_controller]: Timestamp in header is missing, using current time as command timestamp.
[ros2_control_node-1] [WARN] [1749236154.193923786] [bicycle_steering_controller]: Timestamp in header is missing, using current time as command timestamp.
[ros2_control_node-1] [WARN] [1749236154.227070187] [bicycle_steering_controller]: Timestamp in header is missing, using current time as command timestamp.
...
[ros2_control_node-1] [WARN] [1749236154.594182149] [bicycle_steering_controller]: Timestamp in header is missing, using current time as command timestamp.


This is an automatic backport of pull request #828 done by [Mergify](https://mergify.com).

* Add time stamp to TwistStamped msg

* Update per review feedback

* Update per review feedback

* Update per review feedback.

(cherry picked from commit b4021ad)

# Conflicts:
#	example_16/bringup/launch/demo_test_helper.py
#	example_16/doc/userdoc.rst
Copy link
Contributor Author

mergify bot commented Jun 10, 2025

Cherry-pick of b4021ad has failed:

On branch mergify/bp/humble/pr-828
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b4021ad.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   example_11/doc/userdoc.rst
	modified:   example_2/doc/userdoc.rst

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   example_16/bringup/launch/demo_test_helper.py
	deleted by us:   example_16/doc/userdoc.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 10, 2025
@christophfroehlich christophfroehlich merged commit a64a4a3 into humble Jun 10, 2025
3 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-828 branch June 10, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants