Skip to content

Doc for backward blind #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 16, 2025
Merged

Conversation

ajtudela
Copy link
Contributor

No description provided.

ajtudela added 3 commits May 13, 2025 13:38
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
ajtudela and others added 4 commits May 16, 2025 09:56
Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
@SteveMacenski
Copy link
Member

This branch has conflicts that must be resolved

Can you resolve :-)

ajtudela added 2 commits May 16, 2025 19:28
Signed-off-by: Alberto Tudela <[email protected]>
@SteveMacenski
Copy link
Member


fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

@ajtudela
Copy link
Contributor Author


fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Done!

@SteveMacenski
Copy link
Member

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

@SteveMacenski SteveMacenski merged commit b0813bd into ros-navigation:master May 16, 2025
4 checks passed
@ajtudela
Copy link
Contributor Author

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

Sure!

@ajtudela ajtudela deleted the back_dock branch May 19, 2025 07:46
@ajtudela
Copy link
Contributor Author

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

In humble, the direction/backward parameter is still on the server side. How do you want to handle this?

@SteveMacenski
Copy link
Member

SteveMacenski commented May 19, 2025

Add the blind bit on the server side too I guess. Maybe we should have in the main version the same backporting warnings if the blind docking is set in the server rather than plugin for future migrations. We can just throw and require an update for this feature rather than trying to handle it for them automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants