Skip to content

Commit 4e5d2df

Browse files
deprecating C API for TF2 and fixing test failures (#4823)
* deprecating C API for TF2 and fixing test failures Signed-off-by: Steve Macenski <[email protected]> * Update costmap_2d_ros.cpp Signed-off-by: Steve Macenski <[email protected]> * Update 2d_utils_test.cpp Signed-off-by: Steve Macenski <[email protected]> * fix remaining issue Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]>
1 parent 3763f78 commit 4e5d2df

File tree

56 files changed

+79
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+79
-76
lines changed

nav2_amcl/src/amcl_node.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@
3535
#include "nav2_util/string_utils.hpp"
3636
#include "nav2_amcl/sensors/laser/laser.hpp"
3737
#include "rclcpp/node_options.hpp"
38-
#include "tf2/convert.h"
39-
#include "tf2/utils.h"
38+
#include "tf2/convert.hpp"
39+
#include "tf2/utils.hpp"
4040
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
41-
#include "tf2/LinearMath/Transform.h"
41+
#include "tf2/LinearMath/Transform.hpp"
4242
#include "tf2_ros/buffer.h"
4343
#include "tf2_ros/message_filter.h"
4444
#include "tf2_ros/transform_broadcaster.h"

nav2_behavior_tree/include/nav2_behavior_tree/ros_topic_logger.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "rclcpp/rclcpp.hpp"
2424
#include "nav2_msgs/msg/behavior_tree_log.hpp"
2525
#include "nav2_msgs/msg/behavior_tree_status_change.h"
26-
#include "tf2/time.h"
26+
#include "tf2/time.hpp"
2727
#include "tf2_ros/buffer_interface.h"
2828

2929
namespace nav2_behavior_tree

nav2_behavior_tree/plugins/action/remove_in_collision_goals_action.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
#include "nav2_behavior_tree/plugins/action/remove_in_collision_goals_action.hpp"
2020
#include "nav2_behavior_tree/bt_utils.hpp"
21-
#include "tf2/utils.h"
21+
#include "tf2/utils.hpp"
2222
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
2323

2424
namespace nav2_behavior_tree

nav2_behavior_tree/plugins/action/truncate_path_local_action.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#include "nav2_util/robot_utils.hpp"
2525
#include "nav_msgs/msg/path.hpp"
2626
#include "rclcpp/rclcpp.hpp"
27-
#include "tf2/LinearMath/Quaternion.h"
27+
#include "tf2/LinearMath/Quaternion.hpp"
2828
#include "tf2_ros/buffer.h"
2929
#include "tf2_ros/create_timer_ros.h"
3030

nav2_behavior_tree/plugins/condition/transform_available_condition.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include <string>
1818

1919
#include "rclcpp/rclcpp.hpp"
20-
#include "tf2/time.h"
20+
#include "tf2/time.hpp"
2121
#include "tf2_ros/buffer.h"
2222

2323
#include "nav2_behavior_tree/plugins/condition/transform_available_condition.hpp"

nav2_behavior_tree/test/plugins/action/test_truncate_path_action.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
#include "nav_msgs/msg/path.hpp"
2424
#include "nav2_util/geometry_utils.hpp"
2525
#include "rclcpp/rclcpp.hpp"
26-
#include "tf2/LinearMath/Matrix3x3.h"
27-
#include "tf2/LinearMath/Quaternion.h"
26+
#include "tf2/LinearMath/Matrix3x3.hpp"
27+
#include "tf2/LinearMath/Quaternion.hpp"
2828

2929
#include "behaviortree_cpp/bt_factory.h"
3030

nav2_behaviors/include/nav2_behaviors/timed_behavior.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include "nav2_core/behavior.hpp"
3636
#pragma GCC diagnostic push
3737
#pragma GCC diagnostic ignored "-Wpedantic"
38-
#include "tf2/utils.h"
38+
#include "tf2/utils.hpp"
3939
#pragma GCC diagnostic pop
4040

4141

nav2_behaviors/plugins/spin.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include <utility>
2020

2121
#include "nav2_behaviors/plugins/spin.hpp"
22-
#include "tf2/utils.h"
22+
#include "tf2/utils.hpp"
2323
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
2424
#include "nav2_util/node_utils.hpp"
2525

nav2_collision_monitor/include/nav2_collision_monitor/collision_detector_node.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
#include "rclcpp/rclcpp.hpp"
2424

25-
#include "tf2/time.h"
25+
#include "tf2/time.hpp"
2626
#include "tf2_ros/buffer.h"
2727
#include "tf2_ros/transform_listener.h"
2828

nav2_collision_monitor/include/nav2_collision_monitor/collision_monitor_node.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#include "visualization_msgs/msg/marker_array.hpp"
2626
#include "geometry_msgs/msg/twist_stamped.hpp"
2727

28-
#include "tf2/time.h"
28+
#include "tf2/time.hpp"
2929
#include "tf2_ros/buffer.h"
3030
#include "tf2_ros/transform_listener.h"
3131

nav2_collision_monitor/include/nav2_collision_monitor/polygon.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "rclcpp/rclcpp.hpp"
2424
#include "geometry_msgs/msg/polygon_stamped.hpp"
2525

26-
#include "tf2/time.h"
26+
#include "tf2/time.hpp"
2727
#include "tf2_ros/buffer.h"
2828

2929
#include "nav2_util/lifecycle_node.hpp"

nav2_collision_monitor/include/nav2_collision_monitor/source.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
#include "rclcpp/rclcpp.hpp"
2323

24-
#include "tf2/time.h"
24+
#include "tf2/time.hpp"
2525
#include "tf2_ros/buffer.h"
2626

2727
#include "nav2_collision_monitor/types.hpp"

nav2_collision_monitor/src/pointcloud.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include <functional>
1818

1919
#include "sensor_msgs/point_cloud2_iterator.hpp"
20-
#include "tf2/transform_datatypes.h"
20+
#include "tf2/transform_datatypes.hpp"
2121

2222
#include "nav2_util/node_utils.hpp"
2323
#include "nav2_util/robot_utils.hpp"

nav2_collision_monitor/src/polygon.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#include "geometry_msgs/msg/point.hpp"
2121
#include "geometry_msgs/msg/point32.hpp"
22-
#include "tf2/transform_datatypes.h"
22+
#include "tf2/transform_datatypes.hpp"
2323

2424
#include "nav2_util/node_utils.hpp"
2525
#include "nav2_util/robot_utils.hpp"

nav2_collision_monitor/src/polygon_source.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include <functional>
1919

2020
#include "geometry_msgs/msg/polygon_stamped.hpp"
21-
#include "tf2/transform_datatypes.h"
21+
#include "tf2/transform_datatypes.hpp"
2222

2323
#include "nav2_util/node_utils.hpp"
2424
#include "nav2_util/robot_utils.hpp"

nav2_collision_monitor/src/range.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include <cmath>
1919
#include <functional>
2020

21-
#include "tf2/transform_datatypes.h"
21+
#include "tf2/transform_datatypes.hpp"
2222

2323
#include "nav2_util/node_utils.hpp"
2424
#include "nav2_util/robot_utils.hpp"

nav2_collision_monitor/src/scan.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include <cmath>
1818
#include <functional>
1919

20-
#include "tf2/transform_datatypes.h"
20+
#include "tf2/transform_datatypes.hpp"
2121

2222
#include "nav2_util/robot_utils.hpp"
2323

nav2_constrained_smoother/src/constrained_smoother.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include "pluginlib/class_loader.hpp"
3131
#include "pluginlib/class_list_macros.hpp"
3232

33-
#include "tf2/utils.h"
33+
#include "tf2/utils.hpp"
3434

3535
using nav2_util::declare_parameter_if_not_declared;
3636
using nav2_util::geometry_utils::euclidean_distance;

nav2_controller/plugins/simple_goal_checker.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
#include "nav2_util/geometry_utils.hpp"
4444
#pragma GCC diagnostic push
4545
#pragma GCC diagnostic ignored "-Wpedantic"
46-
#include "tf2/utils.h"
46+
#include "tf2/utils.hpp"
4747
#pragma GCC diagnostic pop
4848

4949
using rcl_interfaces::msg::ParameterType;

nav2_costmap_2d/include/nav2_costmap_2d/costmap_2d_publisher.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@
5050
#include "nav2_msgs/msg/costmap.hpp"
5151
#include "nav2_msgs/msg/costmap_update.hpp"
5252
#include "nav2_msgs/srv/get_costmap.hpp"
53-
#include "tf2/transform_datatypes.h"
53+
#include "tf2/transform_datatypes.hpp"
5454
#include "nav2_util/lifecycle_node.hpp"
55-
#include "tf2/LinearMath/Quaternion.h"
55+
#include "tf2/LinearMath/Quaternion.hpp"
5656
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
5757

5858
namespace nav2_costmap_2d

nav2_costmap_2d/include/nav2_costmap_2d/costmap_2d_ros.hpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@
5454
#include "nav2_util/lifecycle_node.hpp"
5555
#include "nav2_msgs/srv/get_costs.hpp"
5656
#include "pluginlib/class_loader.hpp"
57-
#include "tf2/convert.h"
58-
#include "tf2/LinearMath/Transform.h"
57+
#include "tf2/convert.hpp"
58+
#include "tf2/LinearMath/Transform.hpp"
5959
#include "tf2_ros/buffer.h"
6060
#include "tf2_ros/transform_listener.h"
61-
#include "tf2/time.h"
62-
#include "tf2/transform_datatypes.h"
61+
#include "tf2/time.hpp"
62+
#include "tf2/transform_datatypes.hpp"
6363

6464
#pragma GCC diagnostic push
6565
#pragma GCC diagnostic ignored "-Wpedantic"
66-
#include "tf2/utils.h"
66+
#include "tf2/utils.hpp"
6767
#pragma GCC diagnostic pop
6868

6969
namespace nav2_costmap_2d

nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
#include <string>
3939
#include <memory>
4040
#include <algorithm>
41-
#include "tf2/convert.h"
41+
#include "tf2/convert.hpp"
4242
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
4343

4444
#include "nav2_costmap_2d/costmap_filters/keepout_filter.hpp"

nav2_costmap_2d/plugins/static_layer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
#include <string>
4444

4545
#include "pluginlib/class_list_macros.hpp"
46-
#include "tf2/convert.h"
46+
#include "tf2/convert.hpp"
4747
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
4848
#include "nav2_util/validate_messages.hpp"
4949

nav2_costmap_2d/src/footprint_subscriber.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include "nav2_costmap_2d/footprint_subscriber.hpp"
2020
#pragma GCC diagnostic push
2121
#pragma GCC diagnostic ignored "-Wpedantic"
22-
#include "tf2/utils.h"
22+
#include "tf2/utils.hpp"
2323
#pragma GCC diagnostic pop
2424

2525
namespace nav2_costmap_2d

nav2_costmap_2d/src/observation_buffer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
#include <vector>
4343
#include <chrono>
4444

45-
#include "tf2/convert.h"
45+
#include "tf2/convert.hpp"
4646
#include "sensor_msgs/point_cloud2_iterator.hpp"
4747
using namespace std::chrono_literals;
4848

nav2_costmap_2d/test/integration/test_costmap_topic_collision_checker.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include "tf2_ros/transform_broadcaster.h"
3636
#pragma GCC diagnostic push
3737
#pragma GCC diagnostic ignored "-Wpedantic"
38-
#include "tf2/utils.h"
38+
#include "tf2/utils.hpp"
3939
#pragma GCC diagnostic pop
4040
#include "nav2_util/geometry_utils.hpp"
4141

nav2_docking/opennav_docking/include/opennav_docking/simple_charging_dock.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "sensor_msgs/msg/battery_state.hpp"
2424
#include "sensor_msgs/msg/joint_state.hpp"
2525
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
26-
#include "tf2/utils.h"
26+
#include "tf2/utils.hpp"
2727

2828
#include "opennav_docking_core/charging_dock.hpp"
2929
#include "opennav_docking/pose_filter.hpp"

nav2_docking/opennav_docking/include/opennav_docking/simple_non_charging_dock.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "sensor_msgs/msg/battery_state.hpp"
2424
#include "sensor_msgs/msg/joint_state.hpp"
2525
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
26-
#include "tf2/utils.h"
26+
#include "tf2/utils.hpp"
2727

2828
#include "opennav_docking_core/non_charging_dock.hpp"
2929
#include "opennav_docking/pose_filter.hpp"

nav2_docking/opennav_docking/include/opennav_docking/utils.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#include "nav2_util/geometry_utils.hpp"
2525
#include "angles/angles.h"
2626
#include "opennav_docking/types.hpp"
27-
#include "tf2/utils.h"
27+
#include "tf2/utils.hpp"
2828

2929
namespace utils
3030
{

nav2_docking/opennav_docking/src/controller.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "nav2_util/geometry_utils.hpp"
2121
#include "nav2_util/node_utils.hpp"
2222
#include "nav_2d_utils/conversions.hpp"
23-
#include "tf2/utils.h"
23+
#include "tf2/utils.hpp"
2424

2525
namespace opennav_docking
2626
{

nav2_docking/opennav_docking/src/docking_server.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "angles/angles.h"
1616
#include "opennav_docking/docking_server.hpp"
1717
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
18-
#include "tf2/utils.h"
18+
#include "tf2/utils.hpp"
1919

2020
using namespace std::chrono_literals;
2121
using rcl_interfaces::msg::ParameterType;

nav2_docking/opennav_docking/test/test_pose_filter.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include "rclcpp/rclcpp.hpp"
1919
#include "opennav_docking/pose_filter.hpp"
2020
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
21-
#include "tf2/utils.h"
21+
#include "tf2/utils.hpp"
2222

2323
// Testing the pose filter
2424

nav2_docking/opennav_docking/test/test_simple_charging_dock.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "opennav_docking/simple_charging_dock.hpp"
2121
#include "ament_index_cpp/get_package_share_directory.hpp"
2222
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
23-
#include "tf2/utils.h"
23+
#include "tf2/utils.hpp"
2424

2525
// Testing the simple charging dock plugin
2626

nav2_docking/opennav_docking/test/test_simple_non_charging_dock.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "opennav_docking/simple_non_charging_dock.hpp"
2121
#include "ament_index_cpp/get_package_share_directory.hpp"
2222
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
23-
#include "tf2/utils.h"
23+
#include "tf2/utils.hpp"
2424

2525
// Testing the simple non-charging dock plugin
2626

nav2_dwb_controller/nav_2d_utils/include/nav_2d_utils/conversions.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
#include "nav_2d_msgs/msg/pose2_d_stamped.hpp"
4545
#include "nav_msgs/msg/path.hpp"
4646
#include "rclcpp/rclcpp.hpp"
47-
#include "tf2/convert.h"
47+
#include "tf2/convert.hpp"
4848

4949
namespace nav_2d_utils
5050
{

nav2_dwb_controller/nav_2d_utils/src/conversions.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
4949
#pragma GCC diagnostic push
5050
#pragma GCC diagnostic ignored "-Wpedantic"
51-
#include "tf2/utils.h"
51+
#include "tf2/utils.hpp"
5252
#pragma GCC diagnostic pop
5353

5454
#include "nav2_util/geometry_utils.hpp"

nav2_dwb_controller/nav_2d_utils/test/2d_utils_test.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
*/
3434

3535
#include <math.h>
36-
#include <tf2/LinearMath/Quaternion.h>
3736
#include <vector>
37+
#include <tf2/LinearMath/Quaternion.hpp>
3838

3939
#include "gtest/gtest.h"
4040
#include "nav_2d_utils/conversions.hpp"

nav2_graceful_controller/include/nav2_graceful_controller/ego_polar_coords.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#include "angles/angles.h"
2121
#include "geometry_msgs/msg/pose.hpp"
22-
#include "tf2/utils.h"
22+
#include "tf2/utils.hpp"
2323

2424
namespace nav2_graceful_controller
2525
{

nav2_map_server/src/map_io.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646

4747
#include "yaml-cpp/yaml.h"
4848

49-
#include "tf2/LinearMath/Matrix3x3.h"
50-
#include "tf2/LinearMath/Quaternion.h"
49+
#include "tf2/LinearMath/Matrix3x3.hpp"
50+
#include "tf2/LinearMath/Quaternion.hpp"
5151
#include "nav2_util/occ_grid_values.hpp"
5252

5353
#ifdef _WIN32

nav2_mppi_controller/include/nav2_mppi_controller/tools/utils.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
#include "angles/angles.h"
3838

39-
#include "tf2/utils.h"
39+
#include "tf2/utils.hpp"
4040
#include "tf2_geometry_msgs/tf2_geometry_msgs.hpp"
4141

4242
#include "geometry_msgs/msg/twist_stamped.hpp"

0 commit comments

Comments
 (0)