Fix build errors in Ubuntu Lunar when fetched directly #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
ubuntu-lunar-build-errors
branch
from
48a45e8
to
0c9b309
Compare
* Remove double nested include dirs Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
ubuntu-lunar-build-errors
branch
from
0c9b309
to
9cd9436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some build/include errors when building in Ubuntu Lunar (23.04) when compiling nav2 from source.
I've modified the CMakelists to make use of the target_sources command.
The library is now a level higher.
The commands to target_include_directories are properly scoped depending on the directory, especially for the generated export header. No more traversing up directories and back down.
Relates to #419