Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: check_urdf does not take into account transmission tag, wrong behaviour ? #139

Open
Bracewind opened this issue May 1, 2020 · 1 comment

Comments

@Bracewind
Copy link

Bracewind commented May 1, 2020

Hello everyone,

I am not sure this is the right repository, since it is not clear to me whether or not the transmission tag belongs to the urdf specification or the ros_control specification.

when applying check_urdf to a urdf file containing transmissions tag, the node does not check whether or not the joint specified in the transmission tag exists. This makes debugging harder when the package ros_control is used.

Thanks for reading

@clalancette
Copy link
Contributor

The transmission tag is part of the URDF specification here:

<xs:complexType name="transmission">
.

However, the actual parsing and checking of the URDF is done over in https://github.com/ros/urdf/blob/e84c0ce88a37cf78ac456c7fae4b4e9bd7430069/urdf/src/model.cpp for C++ and https://github.com/ros/urdf_parser_py/blob/b6a9726c976933fb8cec0b5b872101984ec131dd/src/urdf_parser_py/urdf.py#L471 for Python.

As you say, it doesn't look like there is any error checking around transmission right now. We would certainly welcome a pull request that implemented that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants