Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support export URDF #199

Open
briansoe66 opened this issue Mar 14, 2024 · 1 comment
Open

support export URDF #199

briansoe66 opened this issue Mar 14, 2024 · 1 comment

Comments

@briansoe66
Copy link

I would like to use the export functions. However, they are deprecated, so that the tinyxml2 dependency is private, as described in: PR #190

I propose changing the API, so that export is available does not use tinyxml2. If this is acceptable, I can create a PR.

URDFDOM_DLLAPI std::string  exportURDF(ModelInterfaceSharedPtr &model);

URDFDOM_DLLAPI std::string  exportURDF(const ModelInterface &model);
@clalancette
Copy link
Contributor

In general, I am OK with that, but you are going to have to call them something different since we want to leave the existing deprecated ones in place for now . That's because in C++ you can't have an overload that differs only in the return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants