Skip to content

Use data() to avoid potentially dereferencing an empty vector (fixes #666) #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

oysstu
Copy link
Contributor

@oysstu oysstu commented Jun 10, 2025

Description

Fixes #666

Very minor change, but fixes this failure when vector assertions are enabled and the endpoint vector is empty.

Is this user-facing behavior change?

No.

Did you use Generative AI?

No.

Additional Information

@ahcorde
Copy link
Contributor

ahcorde commented Jun 10, 2025

Pulls: #667
Gist: https://gist.githubusercontent.com/ahcorde/658a0f0d76a1f8c6b4e342bb50218ed5/raw/7660fb1e01643a6c9d3380e933a82c07ecf7ed9d/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_zenoh_cpp
TEST args: --packages-above rmw_zenoh_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16194

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ahcorde ahcorde merged commit fce38dd into ros2:rolling Jun 11, 2025
5 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Jun 11, 2025

https://github.com/Mergifyio backport kilted jazzy humble

Copy link

mergify bot commented Jun 11, 2025

mergify bot pushed a commit that referenced this pull request Jun 11, 2025
mergify bot pushed a commit that referenced this pull request Jun 11, 2025
mergify bot pushed a commit that referenced this pull request Jun 11, 2025
ahcorde pushed a commit that referenced this pull request Jun 11, 2025
…669)

(cherry picked from commit fce38dd)

Signed-off-by: Øystein Sture <[email protected]>
Co-authored-by: Øystein Sture <[email protected]>
ahcorde pushed a commit that referenced this pull request Jun 11, 2025
…670)

(cherry picked from commit fce38dd)

Signed-off-by: Øystein Sture <[email protected]>
Co-authored-by: Øystein Sture <[email protected]>
Yadunund pushed a commit that referenced this pull request Jun 12, 2025
…668)

(cherry picked from commit fce38dd)

Signed-off-by: Øystein Sture <[email protected]>
Co-authored-by: Øystein Sture <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rmw_zenoh_cpp] get_entities_info_by_topic crashes with gcc vector accessor assertions enabled
3 participants