-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWB: Support defining sensitive config values via k8s secrets #535
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Graham Held <[email protected]>
Hello, I would love to see this merged! 🙏 On my setup, helm chart is deployed through ArgoCD and it doesn't support helm lookup function. This lookup function is the one responsible for checking that launcher.pem+secureCookieKey exists, resulting of those secret values regenerated on every ArgoCD sync. Having those to be set only directly on values.yaml currently to fix this situation is a problem for sensitive value. |
@@ -1,6 +1,6 @@ | |||
name: rstudio-workbench | |||
description: Official Helm chart for Posit Workbench | |||
version: 0.8.7 | |||
version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jforest We will probably want this to be a new minor version
version: 1.0.0 | |
version: 0.9.0 |
hi @pat-s can you please merge a recent main into this? There have been a lot of changes since july, including the addition of helm unittests to run! |
Applies to
launcherPem
secureCookieKey
userPassword
database.conf
When doing so, the
rstudio-secret
is skipped and individual mounts containing the above-mentioned secret values are injected.This PR is breaking as the items listed are now maps and existing deployments would need to migrate from
launcherPem: <value>
tolauncherPem.value: <value>
.I've tested this in a deployment of mine and it works as expected so far.
The advantage of this approach is that it gives power to the users and makes use of "simple" k8s secrets instead of relying on some chart magic which puts together a bundled secret from plain config values.
related #520 #493