Posit Workbench: Support defining sensitive config values via k8s secrets#723
Closed
kaypeter87 wants to merge 2 commits intorstudio:mainfrom
Closed
Posit Workbench: Support defining sensitive config values via k8s secrets#723kaypeter87 wants to merge 2 commits intorstudio:mainfrom
kaypeter87 wants to merge 2 commits intorstudio:mainfrom
Conversation
Author
|
Closing as the original author of #535 is currently engaged and active on the original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is copied over from #535 due to the inactivity of the original author. I have also added the suggested changes from the reviewer.
Applies to
When doing so, the
rstudio-secretis skipped and individual mounts containing the above-mentioned secret values are injected.This PR is breaking as the items listed are now maps and existing deployments would need to migrate from
launcherPem: <value>tolauncherPem.value: <value>.@pat-s tested this in a deployment of theirs and it works as expected so far.
The advantage of this approach is that it gives power to the users and makes use of "simple" k8s secrets instead of relying on some chart magic which puts together a bundled secret from plain config values.
related #520 #493