-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPM: implement service.targetPort as configurable #648
Conversation
@@ -85,6 +85,8 @@ service: | |||
nodePort: false | |||
# -- The Service port. This is the port your service will run under. | |||
port: 80 | |||
# -- The port to forward to on the Package Manager pod. Also see pod.port | |||
targetPort: 4242 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides service.targetPort
and pod.port
, there are a bunch of other 4242
references in the values, like the config.HTTP.Listen = :4242
setting, liveness/startup probe. I assume users would have to find-and-replace all 4242
references manually to fully change the running port?
Is it possible to use a template variable here so you only have to set 4242
once somewhere?
Otherwise this is fine of course, as it's still better than what we had before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service.targetPort was hard coded as port 4242. Modifed this to be a configurable value to support use cases when customer requires routing to alternate port.
Also implemented
pod.port
andpod.hostAliases