feat: add redis support in shopify pixel for id stitching #3957
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3957/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3957 +/- ##
===========================================
- Coverage 90.75% 90.73% -0.02%
===========================================
Files 622 623 +1
Lines 32516 32556 +40
Branches 7718 7726 +8
===========================================
+ Hits 29511 29541 +30
- Misses 2749 2787 +38
+ Partials 256 228 -28 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Utsab Chowdhury <[email protected]>
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
Outdated
Show resolved
Hide resolved
| @@ -125,6 +127,13 @@ const processEvent = async (inputEvent, metricMetadata) => { | |||
| const anonymousId = getAnonymousIdFromAttributes(event); | |||
| if (isDefinedAndNotNull(anonymousId)) { | |||
| message.setProperty('anonymousId', anonymousId); | |||
| } else { | |||
| // if anonymousId is not present in note_attributes or note_attributes is not present, query redis for anonymousId | |||
| const cartToken = getCartToken(event, message); | |||
There was a problem hiding this comment.
redis call should be made only if valid cartToken exists
const cartToken = event?.cart_token;
do we need getCartToken function ?
There was a problem hiding this comment.
Updated.
Keeping it in a separate function gives better readability to the functionality and also if any additional related logic comes up, can be abstracted to the function.
* chore: add campaign object support in web pixel events * chore: add custom utm support
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
What are the changes introduced in this PR?
Add redis support in shopify pixel for id stitching
What is the related Linear task?
Resolves INT-3056
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.